New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GM_openInTab open as child scriptish #276
Comments
The commit 3b9c542 introduces compatibility with Scriptish 0.1.7. |
I tried new commit code and it has problem. The new tab opens as child tab of focused tab, not the tab it was fired from. So if your tab bar looks like this Tab1 - has focus It becomes this: In greasemonkey the new tab attaches to Tab2 because the GM_openInTab command came from that tab |
Hmm, how can I find the tab GM_openInTab is called from? |
I think that it is the best solution: Scriptish calls TST's public APIs ( http://piro.sakura.ne.jp/xul/_treestyletab.html.en#api ) by self. Because 3b9c542 is just a dirty hack, there are limitations as you told... |
I'm unsure how to find tab GM_openInTab is called from. I'm very new to programming. In greasemonkey, it works correctly. Can't you do same thing for scriptish that you did to make greasemonkey work? ..... Or other fix i can think of is to add api that can be set from user script? greasemonkey and scriptish have command unsafeWindow. Maybe TST can monitor special variable on page to act? So user script can write: unsafeWindow.TreeStyleTabService = "readyToOpenChildTab"; I don't know if that's possible, but it may be good solution because then you don't have to make dirty hacks for future versions of greasemonkey and scriptish or any other user script extension that is created. |
Yesterday I read source codes of Scriptish, and it is very different from the current Greasemonkey...
"unsafeWindow" is the "window" object of the web page itself. Adding extra APIs to the object means "provide new web API for any website". It can be a security issue, and, I'll have to write more and more codes to avoid such security problems. I think it is out of focus of TST. (And, adding extra APIs to the "unsafeWindow" requires more hacks for each addon, Greasemonkey and Scriptish.) |
I've realized that the Scriptish is developed under GitHub: https://github.com/scriptish/scriptish |
scriptish/scriptish#9 pull request |
I close this issue because a new version of TST is released. If the problem still there, please comment here. Thanks. |
https://addons.mozilla.org/en-US/firefox/addon/scriptish/
Hi, scriptish is forked better version of greasemonkey. For greasemonkey you made function GM_openInTab open as child tabs. Can you do same for scriptish ?
The text was updated successfully, but these errors were encountered: