Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Send tab to Android (Fennec) #3174

Closed
dflvunoooooo opened this issue Aug 24, 2022 · 14 comments
Closed

[Bug] Send tab to Android (Fennec) #3174

dflvunoooooo opened this issue Aug 24, 2022 · 14 comments
Labels
bug Firefox-issue bug of Firefox itself stale no reaction got for a long term

Comments

@dflvunoooooo
Copy link

Abstract

It is not possible to send a tab to fennec on android.

Steps to reproduce

  1. Start Firefox.
  2. Install TST.
  3. Start Fennec nightly.
  4. install TST from collection.
  5. Right click on a Tab in Firefox.
  6. Select "Send tab to device".

Expected result

I expected my fennec instance to appear to select as a target to send tabs to.

Actual result

No device is listed.

Environment

  • Platform (OS): Arch Linux and Android 12.
  • Version of Firefox: 104
  • Version (or revision) of Tree Style Tab: 3.8.26

I know that fennec is not supported. But sending tabs is the most important feature of Firefox for me.

I have TST installed in fennec with the collection "trick", but I can not even open the settings of TST to give this device a name. Would it work if this would be possibel?

Is there something I can do?

@irvinm
Copy link
Contributor

irvinm commented Aug 24, 2022

@piroor will certainly comment, but I do not think this will be possible. Even if you are able to install TST in Fennec, it won't be able to run there as there is no sidebar support. If it doesn't run, it won't be able to use Firefox Sync to pass tabs between instances.

image

@dflvunoooooo
Copy link
Author

Thanks for the fast answer. I see, makes sense not to loose the tree hierarchy. And there is no way to get the standard Firefox send to device option too? Than, one could send the tab the "old way", without tree structure via Firefox Sync and with the TST send to device with tree structure.

@irvinm
Copy link
Contributor

irvinm commented Aug 25, 2022

As I recall, the WebExt API (addon API) does not have access to be able to interact with the native Firefox "Send Tab to Device" functionality. I believe TST has a workaround for this by populating the information in the Firefox Sync mechanism and hence why this only works when TST is installed on both ends.

If you really need to be able to send a tab to Fennec, I think the only way to do that is via the native tab option of "Send Tab to Device" but obviously that does not pass across the "Parent ID" and hence they are all sent as just individual tabs without tree information being maintained.

I know there is a feature request in bugzilla to allow addons access to that functionality.

@piroor
Copy link
Owner

piroor commented Aug 25, 2022

@piroor piroor added Firefox-issue bug of Firefox itself and removed needs-triage labels Aug 25, 2022
@piroor
Copy link
Owner

piroor commented Aug 25, 2022

Oops, sorry I missed this section:

I know that fennec is not supported. But sending tabs is the most important feature of Firefox for me.

I have TST installed in fennec with the collection "trick", but I can not even open the settings of TST to give this device a name. Would it work if this would be possibel?

Is there something I can do?

A special URL ext+treestyletab:options should be available if TST's protocol handler works. Could you try it?

@dflvunoooooo
Copy link
Author

dflvunoooooo commented Aug 25, 2022

@piroor No problem. I would love to, but I do not really understand what I am supposed to do. Would you please be so to explain that?

@dflvunoooooo
Copy link
Author

dflvunoooooo commented Aug 25, 2022

@irvinm

[…] and hence they are all sent as just individual tabs without tree information being maintained.

I don't mind that. Since TST isn't really working on Fennec, the hierarchy of my tabs must not be preserved, but I extensively use the "send tab to device" function.

@irvinm
Copy link
Contributor

irvinm commented Aug 25, 2022

@piroor No problem. I would love to, but I do not really understand what I am supposed to do. Would you please be so to explain that?

I think he is asking you to type that into the URL bar in Fennec and see if it loads the TST options page. If it does, then it means that TST is actually running although there is no sidebar support. If it doesn't then it isn't running at all.

@dflvunoooooo
Copy link
Author

Ah, I tried that, but fennec uses the search engine and can not open it otherwise.

@piroor
Copy link
Owner

piroor commented Sep 6, 2022

Hmm, does the command "Manage Devices..." under "Send Tab to Device" work? If it is missing in the menu you looks to use Firefox's native tab context menu instead of the menu on TST's sidebar. I've experimentally expose the menu for Fennec's native context menu (it is not tested by me) with the commit 3f26df4 and it should open TST's options page to manage the device name.

@dflvunoooooo
Copy link
Author

There is no option "Manage Devices …". In Fennec one can only share a tab, and if you are logged in to firefox-sync than there are all other firefox-sync devices listed. In firefox on my desktop, I get to the settings page of TTS.

@piroor
Copy link
Owner

piroor commented Oct 10, 2022

You cannot see "Manage Devices …" in tab context menu: it means that TST cannot provide any special menu command for Fennec. Thus we looks to do something for Fennec specially, but currently TST does not support Fennec officially and I have very limited motivation to research for TST on Fennec which does not provide effective place to show tree of tabs...

It is not promised but if you create a pull request of TST to support Fennec and it is reasonable I can merge it. Could you try that?

@github-actions
Copy link

This issue has been labeled as "stale" due to no response by the reporter within 1 year (and 7 days after last commented by someone). And it will be closed automatically 14 days later if not responded.

@github-actions github-actions bot added the stale no reaction got for a long term label Sep 13, 2023
@github-actions
Copy link

This issue has been closed due to no response within 14 days after labeled as "stale", 7 days after last reopened, and 7 days after last commented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Firefox-issue bug of Firefox itself stale no reaction got for a long term
Projects
None yet
Development

No branches or pull requests

3 participants