Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Drag and drop parent-child / subtree broken on 4.0.11 #3521

Closed
natenate19 opened this issue Apr 5, 2024 · 2 comments
Closed

[Bug] Drag and drop parent-child / subtree broken on 4.0.11 #3521

natenate19 opened this issue Apr 5, 2024 · 2 comments

Comments

@natenate19
Copy link

Abstract

Drag and drop of a tab onto an existing tab outside of an existing parent-child relation is broken.

Steps to reproduce

  1. Start Firefox with clean profile.
  2. Install TST.
  3. Open a bunch of tabs
  4. Try to drag the last tab, or any tab, onto an existing tab to create a parent-child tab relation / subtree.

Expected result

Drag and dropping a tab onto another should create a new subtree / parent-child relation.

Actual result

It is impossible to drop one tab onto another. It is possible to place the dragged tab above or below an existing tab, but not to create a new subtree by dropping onto the tab. If there is an existing parent-child subtree, it is possible to drag and drop a tab into that subtree however.

Screenshot 2024-04-04 at 10 31 43 PM
Screenshot 2024-04-04 at 10 42 20 PM

The behavior is also very inconsistent, sometimes it behaves as expected, usually not though as tab list grows in size. Sometimes reloading TST in the sidebar will resolve the issue for a short while, but then it will appear again.

This is similar to #3519, but not the same I don't think, as there is no custom tab-size component.

Environment

  • Platform (OS): macOS 14.4.1
  • Version of Firefox: 124.0.2
  • Version (or revision) of Tree Style Tab: 4.0.11
@piroor
Copy link
Owner

piroor commented Apr 5, 2024

Thanks, the commit 1bf9182 should fix this.

@piroor piroor added fixed and removed needs-triage labels Apr 5, 2024
@natenate19
Copy link
Author

Thanks, working fine on 4.0.12 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants