Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version 4.0.12 changed some of the styling #3526

Closed
sgjohnson1981 opened this issue Apr 9, 2024 · 10 comments
Closed

New version 4.0.12 changed some of the styling #3526

sgjohnson1981 opened this issue Apr 9, 2024 · 10 comments
Labels
bug help wanted stale no reaction got for a long term

Comments

@sgjohnson1981
Copy link

The new update 4.0.12 somehow changed some of the styling. As far as I can tell the borders are different. I don't know enough about CSS to mess around with this. Please change it back.

4.0.11
old_version

4.0.12
new_version

@sgjohnson1981
Copy link
Author

Note: this is the High Contrast theme.

@piroor
Copy link
Owner

piroor commented Apr 10, 2024

Hmm, could you try setting a user style sheet as following?:

:root {
  --tab-border: GrayText;
}

Basically the "High Contrast" theme aims to provide enough contrast for handicappers about their visibility, so it prefers visibility than elegantism. In previous version the border color is defined as "ButtonShadow" but it is now same to "ButtonFace" which is used for tab faces, on recent version Firefox (I don't know it is an intentional change or a unintentional bug). "ButtonBorder" also looks too thin, so I chose "ButtonText" for the border color - which definitely have enough contrast.

But I agree that too high contrast is also not a best choice. I think that "GrayText" - it is for text color of disabled UIs - should be between "ButtonText" and "ButtonFace" and the better choice for this case. How do you think?

piroor added a commit that referenced this issue Apr 10, 2024
…e "High Contrast" theme, to reduce stresses from too high contrast. #3526

`GrayText` is expected that is between `ButtonText` and `ButtonFace`.
@sgjohnson1981
Copy link
Author

I have no idea what you're referring to. GrayText is similar enough to what it was. I tried playing around with the instructions for inspecting the add-on but I couldn't figure it out.

@piroor
Copy link
Owner

piroor commented Apr 10, 2024

Sorry for less description. Here is detailed instructions:

  1. Start Firefox.
  2. Install TST.
  3. Go to TST Options.
  4. Appearance => Choose "High Contrast"
  5. Advanced => User Style Sheet => add a style declaration :root { --tab-border: GrayText; }

@sgjohnson1981
Copy link
Author

Sorry, I wasn't clear either. I meant the second part about the different property tags. If you just enter "GrayText" I don't understand what all the other things have to do with it. Though I am curious what other colors are available.

When I said "GrayText is similar enough" I meant I was able to change it with the CSS you included and it seems similar enough to what was in 4.0.11.

@piroor
Copy link
Owner

piroor commented Apr 10, 2024

System colors are defined at https://www.w3.org/TR/css-color-4/#typedef-system-color but please note that chose colors may be rendered differently on other environments, for example "ButtonFace" will be a light gray and "ButtonText" will be black on environments with "Light" color scheme but "ButtonFace" will be dark gray and "ButtonText" will be white on environments with "Dark" color scheme. We addon developer need to choose better combination which is effective on various environments as possible as we can.

@SteveFromAccounting
Copy link

This worked, thanks! This changed with the recent update in both macOS Ventura as well as Windows, but changing it back to GrayText using the HighContrast theme still made it look black for me, so I just set it to rgb(210, 210, 214) manually for myself.

@ssergiienko
Copy link

jFYI for someone who it might be useful. I got best results with --tab-border: ButtonBorder; which is good both in regular mode and at dark incognito.

Copy link

This issue has been labeled as "stale" due to no response by the reporter within 1 month (and 7 days after last commented by someone). And it will be closed automatically 14 days later if not responded.

@github-actions github-actions bot added the stale no reaction got for a long term label May 10, 2024
Copy link

This issue has been closed due to no response within 14 days after labeled as "stale", 7 days after last reopened, and 7 days after last commented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted stale no reaction got for a long term
Projects
None yet
Development

No branches or pull requests

4 participants