Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small conflict with Sidebars List extension: tab bar isn't updated after exiting from fullscreen mode #546

Closed
Infocatcher opened this issue Aug 24, 2013 · 10 comments

Comments

@Infocatcher
Copy link
Contributor

Sidebars List: https://addons.mozilla.org/addon/sidebars-list/

By default Sidebars List uses different splitter width for maximized and not maximized window.
TST correctly updates after maximize/restore, but not after exiting from fullscreen mode.

@piroor
Copy link
Owner

piroor commented Aug 26, 2013

I've seen two splitter-like areas and extensions.treestyletab.tabbar.togglerSize=0 collapses the wider one (it is provided by TST). Did you talk about it?

@Infocatcher
Copy link
Contributor Author

Sorry, I forgot to test without menu bar.

Initial state, all OK:
fx23_tree_style_tab sidebars_list
Press F11 to enter fullscreen mode:
fx23_tree_style_tab sidebars_list_fullscreen
Press F11 again to exit fullscreen mode (tabs are placed as for thin Sidebars List's splitter):
fx23_tree_style_tab sidebars_list_after_fullscreen

@Infocatcher
Copy link
Contributor Author

P.S. Probably small splitter width doesn't work for you:
Infocatcher/Sidebars_List#3
But you can increase it from extension's options – should be different values for maximized and normal window.

@piroor
Copy link
Owner

piroor commented Oct 8, 2013

I've confirmed the issue you told on #546 (comment) and the commit 4004ec6 should fix it.

@Infocatcher
Copy link
Contributor Author

Strange, works for me on Firefox 24.0 with clean profile, but still buggy on my regular profile.
Seems that patch from #571 finally fixes this bug for me.

@Infocatcher
Copy link
Contributor Author

Something related.
Firefox 26.0 with clean profile + Tree Style Tab 0.14.2013121400a220654 + Sidebars List 0.1.1 (or current development version).
Open Sidebars List options, change corresponding option for splitter width – tab bar isn't updated.

@Infocatcher
Copy link
Contributor Author

P.S. Also I sometimes see this bug after restoring window from minimized state.

Infocatcher added a commit to Infocatcher/Sidebars_List that referenced this issue Jan 31, 2014
Probably releted to piroor/treestyletab#546
And now we should do nothing after window restoring from minimized state + also see 99ce037 commit.
@Infocatcher
Copy link
Contributor Author

Open Sidebars List options, change corresponding option for splitter width – tab bar isn't updated.

Still buggy for me.

P.S. Also I sometimes see this bug after restoring window from minimized state.

Probably fixed by Infocatcher/Sidebars_List@5af2671 commit. Or by something from Tree Style Tab side... Seems like I never see this during last month.

Infocatcher added a commit to Infocatcher/Sidebars_List that referenced this issue Feb 28, 2014
@Infocatcher
Copy link
Contributor Author

OK, I also implemented simple workaround to force update tab bar from my side: Infocatcher/Sidebars_List@ce45b09

@piroor
Copy link
Owner

piroor commented Feb 12, 2016

I close this issue because a new version of TST is released. If the problem still there, please comment here. Thanks.

@piroor piroor closed this as completed Feb 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants