Improve performance of updateVisualMaxTreeLevel when animation is disabled #3384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When closing many tabs at once with animation disabled, we would previously call updateVisualMaxTreeLevel for every tab close event we received. This is extremely slow. Instead, delay the update until the next frame to batch multiple tab close events together.
|
Thanks a lot, but I have a concern: this change introduces a visual regression. When a deeply nested tree is expanded, you'll see an expanded tree with old indentations and it is updated to correct indentations with a delay. Hmm, how can we avoid that... |
|
I close this PR because it is outdated by the change 5fa5f8d which is inspired from this PR. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3383.
With animation disabled, we were previously updating the max tree level every time we received a tab event. When closing large numbers of tabs, this gets extremely slow.
This PR changes it to batch the updates so they only occur once per frame at most.
I wasn't sure whether to go with a 0ms delay (so it appears instantaneous) or a 100ms delay (like reserveToUpdateIndent does just below). I went with a 0ms delay in the end so as to preserve existing behavior.
Maybe for a future PR, it would be nice to do something like what Lodash.debounce offers with
options.leading: the first time we receive the event, we apply it instaneously, but every event after that gets queued up with a certain delay. This would prevent visual feedback from being too delayed, while giving a good "buffer zone" to avoid updating too frequently.