Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "break-inside: avoid" to "li" items using default favicon #3435

Merged
merged 1 commit into from Jan 25, 2024

Conversation

irvinm
Copy link
Contributor

@irvinm irvinm commented Jan 25, 2024

Related to #3361. Feel free to modify as you feel.

@@ -124,6 +124,10 @@
mask-image: url("./icons/folder.svg");
}

li.use-default-favicon.group-tab {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.group-tab looks unnecessary.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After more research I've realized that we just need to add break-inside: avoid to the line 125. I'll do this after merging.

@piroor piroor merged commit 06eb5fb into piroor:trunk Jan 25, 2024
1 check passed
@piroor
Copy link
Owner

piroor commented Jan 25, 2024

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants