fixed define command
#13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
* added `dont-repeat` command * tests: * renamed "document.gdb" to command".gdb * test.gdb: moved entries to hook.gdb / command.gdb
pirpyn
requested changes
Feb 8, 2023
There was a problem hiding this comment.
I prefer to have both define.gdb & document.gdb, even if document use a commandname from command.
Also reading the doc, define & define-prefix are different in what they do, so we have to separate them especially since i didn't grasp the differences between them
| @@ -214,6 +214,13 @@ | |||
| "2": { "name": "constant.numeric.count.ignore.gdb" } | |||
| } | |||
| }, | |||
| { | |||
| "name": "meta.command.dont.gdb", | |||
There was a problem hiding this comment.
I prefer to use the full command name for "name" field, to avoid ambiguities so meta.command.dont-repeat.gdb
| @@ -774,7 +781,7 @@ | |||
| }, | |||
| { | |||
| "name": "meta.block.define-command.gdb", | |||
| "begin": "^[ \t]*(define(?:-prefix)?\\b[ \t]+comm(?:a(?:n(?:d)?)?)?)[ \t]+([^[ \t]]+)[ \t]*$", | |||
| "begin": "^[ \t]*(define(?:-prefix)?)[ \t]+([^[ \t]]+)[ \t]*$", | |||
There was a problem hiding this comment.
|
@pirpyn Would you mind taking this over? |
Sure, likely tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some unknown reason I've added that wrong, there's no "command" in the define command.
Change details:
definecommanddont-repeat(commonly only used indefine, but not raising an error outside either)