feat: correctly handle process.exit calls outside of a task #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metcoder95
force-pushed
the
handleProcessExit2
branch
from
cd1022c
to
041dcf4
Compare
|
The issue is quite interesting, I've tried to isolate it and see what can be done but it works locally at the three different versions it fails but it succeeds on all of them. I'll give it a try with |
|
Ok, yeah I will look more seriously into this hopefully at some point this week |
…into handleProcessExit2
|
Pardon the incoming commits, while I fiddle with getting |
metcoder95
reviewed
Jun 25, 2023
metcoder95
approved these changes
Jun 28, 2023
metcoder95
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clone of this PR made to help avoid some CI troubles
Attempts to fix #304