Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update piscina dependency to v4.3.1. #4020

Merged
merged 1 commit into from Feb 14, 2024

Conversation

garg3133
Copy link
Member

@garg3133 garg3133 commented Feb 9, 2024

Updating Piscina dependency to the latest version (v4.3.1) partially solves issue #4009 in that the main process no longer exits completely without showing any error in case of uncaughtException or unhandledRejection in one of the worker threads. Instead, any such error in worker threads is handled properly now, thanks to piscinajs/piscina#361, and the error message appears in the console output of the affected test suites.

But there are still two issues remaining to be resolved for such cases:

  • In case of an unhandledRejection or uncaughtException, the browser session is not closed properly and the browser window remains open while the test run exits. This happens in both serial and parallel mode of execution.
  • While the process does not exit now in case of error in a worker thread and the error appears in the console output, the final report does not show any error, which might lead to errors in such cases getting missed out.

Copy link

github-actions bot commented Feb 9, 2024

Status

  • ❌ No modified files found in the types directory.
    Please make sure to include types for any changes you have made. Thank you!.

@garg3133 garg3133 changed the title deps: Update piscina to latest version. deps: Update piscina dependency to v4.3.1. Feb 9, 2024
@AutomatedTester AutomatedTester merged commit 88df1d8 into nightwatchjs:main Feb 14, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants