feat(atomics): add environment variable to disable atomics #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
reviewed
Dec 6, 2021
jasnell
previously approved these changes
Dec 6, 2021
SamVerschueren
force-pushed
the
fix/disable-atomics-env
branch
from
c17a99e
to
184558b
Compare
|
I've also replaced |
d3lm
previously approved these changes
Dec 7, 2021
jasnell
previously approved these changes
Dec 7, 2021
|
Sorry. I just saw that I had to disable a lint rule for the |
d3lm
approved these changes
Dec 7, 2021
jasnell
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 馃憢 !
As discussed privately, it would be nice for runtimes to disable the use of
Atomicsglobally as it does not change the outcome at all. A runtime like WebContainer runs in the browser and is currently not capable of implementingreceiveMessageOnPortas the browser does not have such implementation.By adding this environment variable, we are capable of turning it off in general and make piscina work out-of-the-box in StackBlitz WebContainers.
Feel free to suggest different wording for the readme.
Sam