Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update CI #349

Merged
merged 6 commits into from
Jun 11, 2023
Merged

chore: Update CI #349

merged 6 commits into from
Jun 11, 2023

Conversation

metcoder95
Copy link
Member

The PR aims to update the CI manifest and dependabot scope and cadency to up-to-date settings.
It introduces the following changes:

  • chore: update CI
  • chore: update dependabot manifest
  • chore: sync lockfile

@metcoder95
Copy link
Member Author

Reverted to 12, 14, and 16 as it seems there are changes required to support 18 onwards. I'll address it in a subsequent PR targeting a new branch for dropping support for old Node versions.

cc: @jasnell @RafaelGSS

RafaelGSS
RafaelGSS reviewed Jun 9, 2023
View reviewed changes
.github/workflows/nodejs.yml Outdated
name: Test
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
node-version: [12.x, 14.x, 16.x, 17.x]
runs-on: ${{matrix.os}}
node-version: [12.x, 14.x, 16.x]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't drop 12 and 14 here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was considering it to add the whole drop of v12-14 within the work on next branch, as I think the drop should also sync with a drop of the supported version within engines of package.json. Wdyt?

@metcoder95
Copy link
Member Author

@RafaelGSS, do you have an idea of from where the 13 is coming?
I tried to see where this is coming from but couldn't reach a conclusion. The nodejs.yml does not contains the v13 within the matrix

RafaelGSS
RafaelGSS reviewed Jun 11, 2023
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@metcoder95 I think you can target next and drop v12, v14. So I can release a new major too

@RafaelGSS RafaelGSS mentioned this pull request Jun 11, 2023
Merged
@metcoder95 metcoder95 changed the base branch from current to next June 11, 2023 20:30
@metcoder95
Copy link
Member Author

SGTM, it's done now 👍

@metcoder95 metcoder95 merged commit 4c126f1 into next Jun 11, 2023
20 checks passed
@metcoder95 metcoder95 deleted the core/update_ci branch June 11, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS Awaiting requested review from RafaelGSS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@metcoder95 @RafaelGSS