-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable esModuleInterop
#375
base: current
Are you sure you want to change the base?
Changes from 2 commits
0169d1a
9c8c82b
7b7fa0c
fd2a825
123ee83
39acbe3
bd01d58
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
import { AbortController } from 'abort-controller'; | ||
import { EventEmitter } from 'events'; | ||
import Piscina from '..'; | ||
import Piscina = require('..'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's tackle this differently, by exporting Otherwise, this can potentially break the current user's expectations if There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. does the default export created by TS work as an actual default export in Node? The current one does as it's just There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If exported by default, it will export it as Exporting it as default, and named will enable imports like:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. seems #517 did this 👍 |
||
import { test } from 'tap'; | ||
import { resolve } from 'path'; | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
import Piscina from '..'; | ||
import Piscina = require('..'); | ||
import { | ||
isMovable, | ||
markMovable, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can change the way this is imported as discussed in #374 ?