Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose task interface #565

Merged
merged 15 commits into from
May 31, 2024
Merged

feat: expose task interface #565

merged 15 commits into from
May 31, 2024

Conversation

metcoder95
Copy link
Member

  • chore: split worker pool and task queue implementation
  • refactor: remove leftovers

@metcoder95 metcoder95 requested a review from RafaelGSS May 15, 2024 10:23
@metcoder95
Copy link
Member Author

I'm trying to decouple the Task Queue and Worker Pool implementation so they can grow independently, mostly aiming for enable the work for #536 and do it progressively; I'd target the new balancer work directly to next as safe bet

@metcoder95 metcoder95 force-pushed the chore/structure branch 3 times, most recently from 05e58f4 to 963ae88 Compare May 20, 2024 10:47
Base automatically changed from chore/structure to current May 20, 2024 15:34
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it semver-major?

@metcoder95
Copy link
Member Author

Don't think so, wasn't exported before, but if we want to be careful, we can do so

@metcoder95
Copy link
Member Author

Just wanted to verify if is true that we did not expose these types, and indeed we don't.
The only form to have access to them was through

import type { Task } from 'piscina/dist/types';

Which is not officially supported, instead to access the same types they can do:

import type { PiscinaTask } from 'piscina';

@metcoder95
Copy link
Member Author

I'll be merging the PR, if there's extra feedback, feel free to add it here and I'll address it in further PR

@metcoder95 metcoder95 merged commit 285aa82 into current May 31, 2024
13 checks passed
@metcoder95 metcoder95 deleted the feat/expose-task-interface branch May 31, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants