Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Very slow zooming by mouse wheel in FF #228

Closed
etumyan opened this issue Oct 31, 2014 · 5 comments
Closed

Issue: Very slow zooming by mouse wheel in FF #228

etumyan opened this issue Oct 31, 2014 · 5 comments
Assignees
Labels

Comments

@etumyan
Copy link
Contributor

etumyan commented Oct 31, 2014

I guess issue refers to this code:
/src/js/controller/DrawingController.js:239

delta variable in Chrome returns 120 and in Firefox 6.

Tested in Firefox 30 and Chrome 36 on Ubuntu. In Chrome zooming works fine.

@juliandescottes
Copy link
Collaborator

You're right. We have the mousewheel event which is implemented by Chrome, versus the wheel event implemented by others.

According to MDN the ratio between wheeldelta (from the mousewheel event) and delta (from the wheel event) should be -40 (cf code snippet at the end of https://developer.mozilla.org/en-US/docs/Web/Events/wheel) and I used -2.

Will fix this, thanks !

@juliandescottes
Copy link
Collaborator

Should be fixed now.

@mbabuskov
Copy link

Has this been pushed to the servers? I'm still seeing the same problem on both piskelapp.com and http://juliandescottes.github.io/piskel/ (Using Firefox 33)

@juliandescottes
Copy link
Collaborator

Not released yet. I will update this issue when the fix will be released.

@juliandescottes
Copy link
Collaborator

Released on piskelapp.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants