Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature : Save/Save As keyboard shortcuts on web version #277

Closed
juliandescottes opened this issue Apr 29, 2015 · 1 comment
Closed

Feature : Save/Save As keyboard shortcuts on web version #277

juliandescottes opened this issue Apr 29, 2015 · 1 comment
Labels
feature

Comments

@juliandescottes
Copy link
Collaborator

Follow up to https://github.com/juliandescottes/piskel/issues/257 which implemented this feature for the desktop version.

In the webapp version, the default saving mechanism should be :

  • to the gallery if on piskelapp.com, logged in, on own sprite
  • to the browser local storage if logged out or on another user's sprite

Would be nice to add a way to directly "save as" when using the editor on another user's sprite.
@juliandescottes juliandescottes added this to the v0.6 milestone Apr 29, 2015
juliandescottes added a commit that referenced this issue Sep 19, 2015
@juliandescottes
Issue #277 : Move storage services to dedicated package
90e4944
juliandescottes added a commit that referenced this issue Sep 19, 2015
@juliandescottes
Issue #277 : Extract save panel css to dedicated file
d5c0fca
juliandescottes added a commit that referenced this issue Sep 19, 2015
@juliandescottes
Issue #277 : Add new css file to style list
1e816a8
juliandescottes added a commit that referenced this issue Sep 19, 2015
@juliandescottes
Issue #277 : Add global StorageService, enable CTRL+S
fc1d3d3
juliandescottes added a commit that referenced this issue Sep 19, 2015
@juliandescottes
Issue #277 : Move all name update logic to a dedicated controller pol…
0d8d752 
…ling the model
juliandescottes added a commit that referenced this issue Sep 20, 2015
@juliandescottes
Issue #277 : Move storage services to dedicated package
551e15e
juliandescottes added a commit that referenced this issue Sep 20, 2015
@juliandescottes
Issue #277 : Extract save panel css to dedicated file
d96c1a9
juliandescottes added a commit that referenced this issue Sep 20, 2015
@juliandescottes
Issue #277 : Add new css file to style list
758cc62
juliandescottes added a commit that referenced this issue Sep 20, 2015
@juliandescottes
Issue #277 : Add global StorageService, enable CTRL+S
6620f7e
juliandescottes added a commit that referenced this issue Sep 20, 2015
@juliandescottes
Issue #277 : Move all name update logic to a dedicated controller pol…
e5be581 
…ling the model
juliandescottes added a commit that referenced this issue Sep 20, 2015
@juliandescottes
Issue #277 : Add isSaving state to storageService
fe98758
@juliandescottes juliandescottes mentioned this issue Sep 24, 2015
Closed
juliandescottes added a commit that referenced this issue Sep 24, 2015
@juliandescottes
Issue #277 : Add unit test for StorageService
acb6fd2
juliandescottes added a commit that referenced this issue Sep 30, 2015
@juliandescottes
Issue #277 : Cleanup save controller
a286d59
juliandescottes added a commit that referenced this issue Sep 30, 2015
@juliandescottes
Issue #277 : Fix FF bug showing native save popup despite preventDefault
669d7a2
juliandescottes added a commit that referenced this issue Sep 30, 2015
@juliandescottes
Issue #277 : Switch HeaderController to events instead of infinite se…
b859857 
…tTimeout
juliandescottes added a commit that referenced this issue Oct 5, 2015
@juliandescottes
Issue #277 : Move storage services to dedicated package
d7d3cbb
juliandescottes added a commit that referenced this issue Oct 5, 2015
@juliandescottes
Issue #277 : Extract save panel css to dedicated file
2e21cdb
juliandescottes added a commit that referenced this issue Oct 5, 2015
@juliandescottes
Issue #277 : Add new css file to style list
8bb4d1a
juliandescottes added a commit that referenced this issue Oct 5, 2015
@juliandescottes
Issue #277 : Add global StorageService, enable CTRL+S
ee958a4
juliandescottes added a commit that referenced this issue Oct 5, 2015
@juliandescottes
Issue #277 : Move all name update logic to a dedicated controller pol…
dfdbf89 
…ling the model
juliandescottes added a commit that referenced this issue Oct 5, 2015
@juliandescottes
Issue #277 : Add isSaving state to storageService
ca65b51
juliandescottes added a commit that referenced this issue Oct 5, 2015
@juliandescottes
Issue #277 : Add unit test for StorageService
7095eda
juliandescottes added a commit that referenced this issue Oct 5, 2015
@juliandescottes
Issue #277 : Cleanup save controller
050f49a
juliandescottes added a commit that referenced this issue Oct 5, 2015
@juliandescottes
Issue #277 : Fix FF bug showing native save popup despite preventDefault
76dbb79
juliandescottes added a commit that referenced this issue Oct 5, 2015
@juliandescottes
Issue #277 : Switch HeaderController to events instead of infinite se…
aae9655 
…tTimeout
@juliandescottes juliandescottes mentioned this issue Oct 7, 2015
Closed
@juliandescottes
Copy link
Collaborator Author

Merged

@juliandescottes juliandescottes removed this from the v0.6 milestone Nov 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@juliandescottes