Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile onTap bug #371

Closed
AlexHolly opened this issue Dec 22, 2015 · 6 comments
Closed

Mobile onTap bug #371

AlexHolly opened this issue Dec 22, 2015 · 6 comments
Assignees
Labels

Comments

@AlexHolly
Copy link
Contributor

Select simple pen.

  1. On a single tap the draw area flashes blue.
  2. On hold tap the draw area flashes blue, now you can only delete pixels.
    2.1 Tap again now you are able to draw again.

What is this blue flashing and is it possible to deactivate it?

@juliandescottes
Copy link
Collaborator

Maintaining a touch event on the same spot triggers a context menu. The context menu event is prevented on the drawing area, but the application still registered a mousedown/tap using the RIGHT mouse button, therefore selecting the secondary color.

By default the secondary color is transparent, which is why it "deletes" pixels. Tapping again retriggers an event for the LEFT button, which gets it back to normal.

So looks like the touch events need a bit more work. I guess we should always use the primary color in case of touch events.

Regarding the blue overlay, I guess it's the default selection overlay, don't know yet how we can deactivate it but that should be doable.

@juliandescottes
Copy link
Collaborator

As suspected the browser is triggering an actual mousedown event with button = 2 (right button).

The best is to call event.preventDefault() in the touchstart event handler.
This also removes the selection overlay mentioned in the issue.

@juliandescottes
Copy link
Collaborator

Should be fixed with v0.7.0, released yesterday on piskelapp.com

@AlexHolly feel free to reopen if this is still occurring (I still have no way to test tablets :/ )
Thanks!

@AlexHolly
Copy link
Contributor Author

Do I have to use the offline version? I can't see any difference on the web version. For a moment I thought this could be a feature but it can really confuse to delete with a pen on simple tap.

Where can I see the piskel version in the web version?

@juliandescottes
Copy link
Collaborator

It is only on http://piskelapp.com for now. https://juliandescottes.github.io/piskel has not been updated yet, and there is no app for mobile devices.

You can tell if you have the new version if there is "1a" displayed on the right of each layer in the layers list :
image

Using in-browser emulators, the behaviour is fine ... I'm afraid I can't do more. Would need someone who has an actual device to spend time on this.

Reopening for now.
@AlexHolly please confirm you have the latest version using what I said above.

@AlexHolly
Copy link
Contributor Author

I can confirm that I tested the new version(with chrome browser).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants