Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings drawers should close on ESCAPE key #392

Closed
juliandescottes opened this issue Jan 30, 2016 · 0 comments · Fixed by #396
Closed

Settings drawers should close on ESCAPE key #392

juliandescottes opened this issue Jan 30, 2016 · 0 comments · Fixed by #396

Comments

@juliandescottes
Copy link
Collaborator

The settings drawers are all the panels that open on the right of the application (application settings, resize, save, export, import).

Right now, the only way to close them is to click outside of the drawer.
It would be nice if hitting "ESCAPE" would do the same. This behavior is already implemented for dialogs.

Hints

The controllers responsible for this area are in src/js/controller/settings. SettingsController.js is the main controller that handles the drawer. Individual controllers (for instance ApplicationSettingsController.js) are only responsible for the content displayed inside the drawer. They are loaded by the SettingsController.

Regarding keyboard shortcuts, you can have a look at src/js/controller/dialogs/DialogsController.js and how it uses "closePopupShortcut" :

pskl.app.shortcutService.registerShortcut(
   this.closePopupShortcut, this.hideDialog.bind(this));

The available keyboard shortcuts are listed in src/js/service/keyboard/Shortcut.

Testing

There is no framework to test this part of the application for now.

@GMartigny GMartigny mentioned this issue Feb 3, 2016
juliandescottes added a commit that referenced this issue Feb 3, 2016
Issue #392 : Allow to close the options drawer with the escape key.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant