Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing "d" for default colors doesn't fully work. #601

Closed
TALANTO opened this issue Dec 29, 2016 · 2 comments
Closed

Pressing "d" for default colors doesn't fully work. #601

TALANTO opened this issue Dec 29, 2016 · 2 comments
Labels

Comments

@TALANTO
Copy link

TALANTO commented Dec 29, 2016

Hello I want to thank you for the great app and share few bugs I've found to make it even better!

When I change the left and right mouse button colors and I press "d" for the default colors they are actually changed but it's not shown in the bottom left corner:

screenshot from 2016-12-29 13-20-40

@juliandescottes
Copy link
Collaborator

Thanks for the bug report!

The issue comes from PaletteController.js and the resetColors method. An option is to remove the reset method from the SelectedColorsService (since it doesn't fire the expected events anyway) and implement PaletteController::resetColors in the same way as PaletteController::swapColors

juliandescottes added a commit that referenced this issue Jan 5, 2017
Pressing "d" for default colors doesn't fully work. #601
@juliandescottes
Copy link
Collaborator

Fixed by #605 , thanks to @Sal0hcine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants