Bug: Canvas workspace disappears/goes grey when zooming in #651
Comments
|
Thanks for opening the issue and adding so much details! I know that canvas elements can fail to render if they are too big (hardware dependent, graphic card and pixel density mostly). I can't understand why the overlay (and most likely layer preview?) would fail to render, but the main canvas would still be ok. You mentioned this only happened with medium/bug sprites? Can you elaborate a bit on that? |
|
@juliandescottes Thanks for replying. By "small" sprites, I mean sprites that can feasibly be worked on when the image's horizontal and vertical boundaries fit the edges of the workspace when zoomed in (e.g. 32x32). By "medium->large", I mean sprites where you would want to zoom in further than that. |
|
Ok! That means the bug still happens if you zoom on small sprites (for instance 32x32), it's just that you don't feel compelled to do it. |
|
Exactly :) |
|
Have you pushed any changes to the production server? Because I am no longer seeing the problem on the Pixel. Either that, or the update from Chrome version 57 to 58 fixed it. |
|
I haven't :/ As you said, Chrome 58 probably fixed it for you (which is great because I couldn't reproduce the issue). The joys of the web platform?! |
|
lokothodida |
|
@720Ultrasmasher: Ctrl+Shift+I (or right-click and |
|
Ok thanks |
|
@TheNetherrackAxe @Mruble Chrome 58 has been released. Can you check if the issue is fixed for you after updating Chrome? |
|
I got an update for the software but it keeps churning grey
…On Sun, Apr 23, 2017 at 5:40 PM, Julian Descottes ***@***.***> wrote:
@TheNetherrackAxe <https://github.com/TheNetherrackAxe> @Mruble
<https://github.com/Mruble> Chrome 58 has been released.
Can you check if te issue is fixed for you after updating Chrome?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/juliandescottes/piskel/issues/651#issuecomment-296490706>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AZrq-8I5By3uJ5W1ChgRYY_d5T7LIN9Xks5ry8U7gaJpZM4MkfIa>
.
--
--
This e-mail message was sent by a student at Hillsborough High School. If
you feel any content in this message is inappropriate or potentially
harmful, please contact hhs_email_abuse@htps.us.
--
--
NOTICE: This e-mail message, including any attachment(s), is for the sole
use of the intended recipient and may contain confidential and privileged
information. Any unauthorized review, use, disclosure or distribution is
prohibited. If you are not the intended recipient, please contact the
sender by reply e-mail and destroy all copies of the original message.
|
|
:( OK thanks for the update, looks like I'm going to have to find a chromebook ... |
|
actually it could be because i am using a school provided chromebook
…On Mon, Apr 24, 2017 at 8:51 AM, Julian Descottes ***@***.***> wrote:
:(
OK thanks for the update, looks like I'm going to have to find a
chromebook ...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/juliandescottes/piskel/issues/651#issuecomment-296656171>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AZrq-y6RtYs-xpOdySH84e2DdfC_y4UXks5rzJq9gaJpZM4MkfIa>
.
--
--
This e-mail message was sent by a student at Hillsborough High School. If
you feel any content in this message is inappropriate or potentially
harmful, please contact hhs_email_abuse@htps.us.
--
--
NOTICE: This e-mail message, including any attachment(s), is for the sole
use of the intended recipient and may contain confidential and privileged
information. Any unauthorized review, use, disclosure or distribution is
prohibited. If you are not the intended recipient, please contact the
sender by reply e-mail and destroy all copies of the original message.
|
|
Yeah, still happening on my school chrome too... (sorry for delay) |
|
For people that are having issues in Chrome OS, it would be useful to know:
* can be found by going to Help -> About Chrome OS This can help us narrow down on whether or not it is a browser-specific or device-specific update that fixes the problem. For me, it is (currently):
|
|
Thanks @lokothodida ! Indeed that would be super useful. @grosbouddha tried to reproduce the issue today with an HP Chromebook with version 57, but couldn't trigger the bug. @lokothodida last time you said the issue was gone for you. Is it still the case or did it come back? In the meantime I think I'll try some random fixes and will put various versions up for testing on github. |
|
@juliandescottes Thanks for still looking into the bug! The issue hasn't come back for me (thankfully). |
|
Some investigation first. The gray color from @lokothodida 's screenshots is #A0A0A0 . This color is only used in one spot in the application : to display the zoomed out area. The two main canvas used in the application are the drawing canvas, which contains the current frame+layer, and the overlay canvas, which displays anything temporary (cursor, selection, shapes ...). They are rendered exactly in the same way: From the various screenshots and reports I've seen, it seems like step 5 is not working as expected. It should cut a "hole" in the gray area to make sure the drawing zone is visible, but obviously ... it doesn't. To say it differently, the issue occurs when the clear from step 5 needs to clear the whole canvas. I already had issues with Chrome when using fillRect, clearRect with the maximum height and width ( if anybody's curious : https://bugs.chromium.org/p/chromium/issues/detail?id=469906 ). I'm going to guess it's a similar issue and clearRect at full height + width is buggy? |
|
Now for the more interesting stuff, here are 5 test versions:
If anyone facing this bug could try out the links above and see if any of them fixes the problem that would be great. cc @720Ultrasmasher @TheNetherrackAxe @Mruble @deraj-nagar @Elven-Lord (edit: added a 4th test version) |
|
None of them fix it for me, like I said it could be because I have a school
chromebook. The type of chormebook it is is a Chrome OS, and I don't know
how to check what update I am on. I may have school restrictions
…On Thu, May 4, 2017 at 6:50 PM, Julian Descottes ***@***.***> wrote:
Now for the more interesting stuff, here are 3 test versions:
- http://juliandescottes.github.io/piskel/clear_before_scale/
- http://juliandescottes.github.io/piskel/clear_before_scale_v2/
- http://juliandescottes.github.io/piskel/clear_before_translate/
If anyone facing this bug could try out the links above and see if any of
them fixes the problem that would be great. If my guess in the previous
comment is correct, the first one should not fix the issue, but the last
two might.
cc @720Ultrasmasher <https://github.com/720Ultrasmasher> @TheNetherrackAxe
<https://github.com/TheNetherrackAxe> @Mruble <https://github.com/Mruble>
@deraj-nagar <https://github.com/deraj-nagar> @Elven-Lord
<https://github.com/Elven-Lord>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/juliandescottes/piskel/issues/651#issuecomment-299330745>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AZrq-5ezmHU0HAxWWYMODBZ3UJQVW3epks5r2lY_gaJpZM4MkfIa>
.
--
--
This e-mail message was sent by a student at Hillsborough High School. If
you feel any content in this message is inappropriate or potentially
harmful, please contact hhs_email_abuse@htps.us.
--
--
NOTICE: This e-mail message, including any attachment(s), is for the sole
use of the intended recipient and may contain confidential and privileged
information. Any unauthorized review, use, disclosure or distribution is
prohibited. If you are not the intended recipient, please contact the
sender by reply e-mail and destroy all copies of the original message.
|
|
@720Ultrasmasher thanks for the feedback. Don't you have access to what lokothodida suggested?
|
|
If you are talking about the developer tools, the school restricted that
sadly
…On Fri, May 5, 2017 at 9:05 AM, Julian Descottes ***@***.***> wrote:
@720Ultrasmasher <https://github.com/720Ultrasmasher> thanks for the
feedback. Don't you have access to what lokothodida suggested?
can be found by going to Help -> About Chrome OS
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/juliandescottes/piskel/issues/651#issuecomment-299459399>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AZrq-6jcpOPYICGTSernKY2NPjFqSq7uks5r2x6vgaJpZM4MkfIa>
.
--
--
This e-mail message was sent by a student at Hillsborough High School. If
you feel any content in this message is inappropriate or potentially
harmful, please contact hhs_email_abuse@htps.us.
--
--
NOTICE: This e-mail message, including any attachment(s), is for the sole
use of the intended recipient and may contain confidential and privileged
information. Any unauthorized review, use, disclosure or distribution is
prohibited. If you are not the intended recipient, please contact the
sender by reply e-mail and destroy all copies of the original message.
|
|
I don't believe it is in the developer tools. @lokothodida mentioned clicking "Help -> About Chrome OS". I guess it should be in some kind of general menu in chrome os? |
|
Ok ill try that thanks
…On Fri, May 5, 2017 at 9:12 AM, Julian Descottes ***@***.***> wrote:
I don't believe it is in the developer tools. @lokothodida
<https://github.com/lokothodida> mentioned clicking "Help -> About Chrome
OS". I guess it should be in some kind of general menu in chrome os?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/juliandescottes/piskel/issues/651#issuecomment-299460823>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AZrq-xWBHqwziuwv2noWR710aUnUmkGbks5r2yA8gaJpZM4MkfIa>
.
--
--
This e-mail message was sent by a student at Hillsborough High School. If
you feel any content in this message is inappropriate or potentially
harmful, please contact hhs_email_abuse@htps.us.
--
--
NOTICE: This e-mail message, including any attachment(s), is for the sole
use of the intended recipient and may contain confidential and privileged
information. Any unauthorized review, use, disclosure or distribution is
prohibited. If you are not the intended recipient, please contact the
sender by reply e-mail and destroy all copies of the original message.
|
|
@720Ultrasmasher if you're still around, can you try this other version: |
|
Thank God, you fixed it this one works fine
…On Fri, May 5, 2017 at 9:18 AM, Julian Descottes ***@***.***> wrote:
@720Ultrasmasher <https://github.com/720Ultrasmasher> if you're still
around, can you try this other version:
http://juliandescottes.github.io/piskel/clear_capped_v2/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/juliandescottes/piskel/issues/651#issuecomment-299462185>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AZrq-9mi7fbyAacT-cRBsAOGwwVyStIsks5r2yGigaJpZM4MkfIa>
.
--
--
This e-mail message was sent by a student at Hillsborough High School. If
you feel any content in this message is inappropriate or potentially
harmful, please contact hhs_email_abuse@htps.us.
--
--
NOTICE: This e-mail message, including any attachment(s), is for the sole
use of the intended recipient and may contain confidential and privileged
information. Any unauthorized review, use, disclosure or distribution is
prohibited. If you are not the intended recipient, please contact the
sender by reply e-mail and destroy all copies of the original message.
|
|
Oh great, finally some progress :) |
|
No problem and thank you for finally being able to fix it. I have a feeling
that it was probably hell for you so really thank you
…On Fri, May 5, 2017 at 9:26 AM, Julian Descottes ***@***.***> wrote:
Oh great, finally some progress :)
This version might not be ideal for actually using the editor, since the
borders will hide a bit the edge of your drawing, but I just need to refine
that now. Thanks for the quick feedback!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/juliandescottes/piskel/issues/651#issuecomment-299464103>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AZrq-2SCVym7XeBCq9EKxDjivUroEq0gks5r2yOdgaJpZM4MkfIa>
.
--
--
This e-mail message was sent by a student at Hillsborough High School. If
you feel any content in this message is inappropriate or potentially
harmful, please contact hhs_email_abuse@htps.us.
--
--
NOTICE: This e-mail message, including any attachment(s), is for the sole
use of the intended recipient and may contain confidential and privileged
information. Any unauthorized review, use, disclosure or distribution is
prohibited. If you are not the intended recipient, please contact the
sender by reply e-mail and destroy all copies of the original message.
|
|
Here is an attempt at a proper fix: http://juliandescottes.github.io/piskel/fix_v1/ Can someone validate that it works for them ? (edit: just got a positive feedback on this version from someone on twitter. additional testing still appreciated :) ) |
|
(I will just leave open until I get some more feedback!) |
|
It works perfectly just like it used to
…On Sat, May 6, 2017 at 5:24 AM, Julian Descottes ***@***.***> wrote:
Here is an attempt at a proper fix:
http://juliandescottes.github.io/piskel/fix_v1/
Can someone validate that it works for them ?
cc @720Ultrasmasher <https://github.com/720Ultrasmasher> @TheNetherrackAxe
<https://github.com/TheNetherrackAxe> @Mruble <https://github.com/Mruble>
@deraj-nagar <https://github.com/deraj-nagar> @Elven-Lord
<https://github.com/Elven-Lord>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/juliandescottes/piskel/issues/651#issuecomment-299627559>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AZrq-yFQHDDQUuawU7-jM3tIGf7f0fB2ks5r3Dw8gaJpZM4MkfIa>
.
--
--
This e-mail message was sent by a student at Hillsborough High School. If
you feel any content in this message is inappropriate or potentially
harmful, please contact hhs_email_abuse@htps.us.
--
--
NOTICE: This e-mail message, including any attachment(s), is for the sole
use of the intended recipient and may contain confidential and privileged
information. Any unauthorized review, use, disclosure or distribution is
prohibited. If you are not the intended recipient, please contact the
sender by reply e-mail and destroy all copies of the original message.
|
|
Thanks for the feedback! Closing now. |
Bug description
When zooming into the canvas, if the zooming obscures the horizontal and vertical boundaries of the image, then the visible canvas turns grey. The layers and preview window(s) are unaffected: it's just what is visible in the active workspace that vanishes. I can draw on the layers and the results will show up in the preview, but I can't see anything in the workspace. It basically means being unable to zoom adequately on medium->large sized sprites. However, I've only seen this problem on the Google Chromebook Pixel 2015. Other devices (e.g. Chromebooks like the Toshiba Chromebook 2014) seem to work fine.
I've not looked into the repository's source code, but when inspecting the page and checking the elements, it seems to be related to the
<canvas>with the class namecanvas-overlay. When I hide it, the workspace becomes visible, but the background becomes grey as well (screenshots included at the bottom).Steps to reproduce the bug
Environment details
Screenshots
Before zooming
After zooming
Opening the inspector
Hiding the overlay canvas
The text was updated successfully, but these errors were encountered: