Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to rename basename for PNG in ZIP export option. #213

Merged
merged 1 commit into from Aug 26, 2014

Conversation

posva
Copy link
Contributor

@posva posva commented Aug 22, 2014

When using texturepackers the name of the file is important as it will be used to generate data.

Currently pixel names all png exported in ZIP to sprite_x.png. I wanted to use the #save-name field but I realized your current setup is not saving text inputs so I added one.

Tell me what do you think about it and feel free to change the text I added.

@juliandescottes
Copy link
Collaborator

Thanks ! Looks good, I'll merge this later today.

(Don't worry about the travis build failing, it's not related to your pull request)

@posva
Copy link
Contributor Author

posva commented Aug 22, 2014

I actually tested it with grunt test and saw it was failing with the same error as for the last travis build so I thought there are some issues with testing at the moment :P
I'm glad it helps 😄

@juliandescottes
Copy link
Collaborator

Sorry, I didn't merge your PR yet :(

I was thinking that we could reuse the name of the piskel (cf ns.PngExportController.prototype.getPiskelName_) as the default value for the prefix ? instead of the current 'sprite_' ?

Of course this only works for saved piskels (either in local storage or on piskelapp.com ).

@juliandescottes juliandescottes merged commit 978319a into piskelapp:master Aug 26, 2014
@juliandescottes
Copy link
Collaborator

Merged to master !

@posva
Copy link
Contributor Author

posva commented Aug 26, 2014

Hey sorry for not answering you reply xD I didn't have quite the time to do it. So yeas, do as you please, I also think it fits better, I just used sprite_ because it was the previous behaviour ^^

@posva
Copy link
Contributor Author

posva commented Aug 26, 2014

Also congrats forp making the tests run again :P

@juliandescottes
Copy link
Collaborator

No worries :) thanks for the contribution ! (I slightly shortened the help text in the final version for info)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants