Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #349 : Frame list slightly scroll on the right #400

Merged
merged 4 commits into from
Feb 12, 2016
Merged

Issue #349 : Frame list slightly scroll on the right #400

merged 4 commits into from
Feb 12, 2016

Conversation

GMartigny
Copy link
Contributor

fix issue #349 and add options on the sortable widget
Frames can now only be dragged by the handle, not sure if wanted. (can be revert)

Signed-off-by:Guillaume Martigny <guillaume.martigny@gmail.com>
fix CSS to prevent horizontal scroll
Signed-off-by:Guillaume Martigny <guillaume.martigny@gmail.com>
update: $.proxy(this.onUpdate_, this),
items: '.preview-tile'
items: '.preview-tile',
axis: 'y',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels much nicer to use, thanks!

@juliandescottes
Copy link
Collaborator

Looks good!

Just keep the whole frame draggable and we'll merge this.

Signed-off-by:Guillaume Martigny <guillaume.martigny@gmail.com>
@GMartigny GMartigny changed the title Issue #349 Issue #349 : Frame list slightly scroll on the right Feb 5, 2016
@juliandescottes
Copy link
Collaborator

I didn't see the PR was updated ... sorry for the delay.
Thanks!

juliandescottes added a commit that referenced this pull request Feb 12, 2016
Issue #349 : Frame list slightly scroll on the right
@juliandescottes juliandescottes merged commit ef7108a into piskelapp:master Feb 12, 2016
@GMartigny GMartigny deleted the issue_#349 branch April 18, 2016 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants