Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made cursor coordinates gold (and whitespace more consistent). #764

Merged
merged 2 commits into from Nov 16, 2017
Merged

Made cursor coordinates gold (and whitespace more consistent). #764

merged 2 commits into from Nov 16, 2017

Conversation

carlsmith
Copy link
Contributor

@carlsmith carlsmith commented Nov 11, 2017

As discussed with @juliandescottes, I've made the cursor coordinates at the bottom of the editor UI gold so they stand out better.

The CSS file (layout.css) generally has spaces after the colon between property names and their values, like name: value, but the rule this edit applies to didn't have the spaces, like name:value, so I added spaces to all four lines, but only otherwise edited one of them.

Copy link
Collaborator

@juliandescottes juliandescottes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one tiny thing and I'll merge. Thanks!

font-size:12px;
font-weight:bold;
font-family:monospace;
color: gold;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use var(--highlight-color) for gold? (defined in variables.css)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, didn't notice this till now. Of course. No problem.

@juliandescottes
Copy link
Collaborator

Sorry I have been away from Piskel for the beginning of the week! Looks good, merging.

@juliandescottes juliandescottes merged commit bcee246 into piskelapp:master Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants