Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to lock layers #951

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/css/font-icon.css
Original file line number Diff line number Diff line change
Expand Up @@ -94,3 +94,11 @@
.piskel-icon-arrow-down-thin:before {
content: "\e60f";
}

.piskel-icon-lock-locked:before {
content: "\e98f";
}

.piskel-icon-lock-unlocked:before {
content: "\e990";
}
Binary file modified src/css/fonts/icomoon.eot
Binary file not shown.
40 changes: 21 additions & 19 deletions src/css/fonts/icomoon.svg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/css/fonts/icomoon.ttf
Binary file not shown.
Binary file modified src/css/fonts/icomoon.woff
Binary file not shown.
4 changes: 4 additions & 0 deletions src/css/toolbox-layers-list.css
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,10 @@
background : #222;
}

.layer-lock {
padding: 6px 0;
}

.layer-item-opacity {
padding: 0 8px 0 8px;
flex: 0 auto;
Expand Down
10 changes: 10 additions & 0 deletions src/js/controller/DrawingController.js
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,11 @@
};

ns.DrawingController.prototype.onTouchstart_ = function (event) {
var index = this.piskelController.getCurrentLayerIndex();
var layer = this.piskelController.getLayerByIndex(index);
if (layer.locked) {
return;
}
this.onMousedown_(event);
};

Expand All @@ -153,6 +158,11 @@
* @private
*/
ns.DrawingController.prototype.onMousedown_ = function (event) {
var index = this.piskelController.getCurrentLayerIndex();
var layer = this.piskelController.getLayerByIndex(index);
if (layer.locked) {
return;
}
$.publish(Events.MOUSE_EVENT, [event, this]);
var frame = this.piskelController.getCurrentFrame();
var coords = this.getSpriteCoordinates(event.clientX, event.clientY);
Expand Down
7 changes: 6 additions & 1 deletion src/js/controller/LayersListController.js
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@
'layername' : layer.getName(),
'layerindex' : index,
'isselected:current-layer-item' : isSelected,
'opacity' : layer.getOpacity()
'opacity' : layer.getOpacity(),
'locked' : layer.locked ? 'locked' : 'unlocked'
});
var layerItem = pskl.utils.Template.createFromHTML(layerItemHtml);
this.layersListEl.insertBefore(layerItem, this.layersListEl.firstChild);
Expand Down Expand Up @@ -181,6 +182,10 @@
var layer = this.piskelController.getLayerAt(parseInt(index, 10));
var opacity = window.prompt('Set layer opacity (value between 0 and 1)', layer.getOpacity());
this.piskelController.setLayerOpacityAt(index, opacity);
} else if (el.classList.contains('layer-lock')) {
index = pskl.utils.Dom.getData(el, 'layerIndex');
var layer = this.piskelController.getLayerAt(parseInt(index, 10));
this.piskelController.setLayerLockedAt(index, layer.getLocked());
}
};

Expand Down
5 changes: 5 additions & 0 deletions src/js/controller/drawing/DragHandler.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@
* @param {Number} y : y coordinate of the mouse event that initiated the drag
*/
ns.DragHandler.prototype.startDrag = function (x, y) {
var index = this.piskelController.getCurrentLayerIndex();
var layer = this.piskelController.getLayerByIndex(index);
if (layer.locked) {
return;
}
var coords = this.drawingController.getSpriteCoordinates(x, y);
this.updateOrigin_(coords.x, coords.y);
};
Expand Down
11 changes: 11 additions & 0 deletions src/js/controller/piskel/PiskelController.js
Original file line number Diff line number Diff line change
Expand Up @@ -284,9 +284,20 @@
}
};

ns.PiskelController.prototype.setLayerLockedAt = function (index, locked) {
var layer = this.getLayerByIndex(index);
if (layer) {
layer.setLocked(!locked);
}
};

ns.PiskelController.prototype.mergeDownLayerAt = function (index) {
var layer = this.getLayerByIndex(index);
var downLayer = this.getLayerByIndex(index - 1);
if (layer.locked || downLayer.locked) {
window.console.error('Could not merge with later below. One of the layers is locked.');
return;
}
if (layer && downLayer) {
var mergedLayer = pskl.utils.LayerUtils.mergeLayers(layer, downLayer);
this.removeLayerAt(index);
Expand Down
1 change: 1 addition & 0 deletions src/js/controller/piskel/PublicPiskelController.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
this.saveWrap_('moveLayerDown', true);
this.saveWrap_('removeCurrentLayer', true);
this.saveWrap_('setLayerOpacityAt', true);
this.saveWrap_('setLayerLockedAt', true);
this.saveWrap_('toggleFrameVisibilityAt', true);

var shortcuts = pskl.service.keyboard.Shortcuts;
Expand Down
12 changes: 12 additions & 0 deletions src/js/model/Layer.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
this.name = name;
this.frames = [];
this.opacity = 1;
this.locked = false;
}
};

Expand Down Expand Up @@ -46,6 +47,17 @@
this.opacity = +opacity.toFixed(3);
};

ns.Layer.prototype.getLocked = function () {
return this.locked;
};

ns.Layer.prototype.setLocked = function (locked) {
if (typeof locked !== 'boolean') {
locked = false;
}
this.locked = locked;
};

ns.Layer.prototype.isTransparent = function () {
return this.opacity < 1;
};
Expand Down
3 changes: 3 additions & 0 deletions src/js/tools/ToolsHelper.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ ns.ToolsHelper = {
var currentFrameIndex = pskl.app.piskelController.getCurrentFrameIndex();
var layers = useAllLayers ? pskl.app.piskelController.getLayers() : [pskl.app.piskelController.getCurrentLayer()];
return layers.reduce(function (previous, layer) {
if (layer.locked) {
return previous;
}
var frames = useAllFrames ? layer.getFrames() : [layer.getFrameAt(currentFrameIndex)];
return previous.concat(frames);
}, []);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@
var dataUriLengthFirstHalf = arr16[currentIndex + 3];
var dataUriLengthSecondHalf = arr16[currentIndex + 4];
var dataUriLength = (dataUriLengthSecondHalf >>> 0) | (dataUriLengthFirstHalf << 16 >>> 0);
var locked = false;

// Name
var layerName = '';
Expand All @@ -97,6 +98,7 @@

layer.name = layerName;
layer.opacity = opacity;
layer.locked = locked;
layer.frameCount = frameCount;
layer.dataUri = dataUri;
layers.push(layer);
Expand Down Expand Up @@ -128,6 +130,7 @@
var nlayer = new pskl.model.Layer(layer.name);
layer.model = nlayer;
nlayer.setOpacity(layer.opacity);
nlayer.setLocked(layer.locked);
piskel.addLayer(nlayer);

loadLayerImage.bind(this, layer, callback)();
Expand Down
3 changes: 3 additions & 0 deletions src/templates/layers-list.html
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ <h3 class="toolbox-title layers-title">Layers
<li class="layer-item {{isselected:current-layer-item}}"
data-layer-index="{{layerindex}}">
<span class="layer-name" data-placement="top">{{layername}}</span>
<span class="layer-lock piskel-icon-lock-{{locked}}"
title="Layer {{locked}}" rel="tooltip" data-placement="top">
</span>
<span class="layer-item-opacity"
title="Layer opacity ({{opacity}})" rel="tooltip" data-placement="top">
&#945;
Expand Down