Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc2Vec.DocvecsArray.doctag_syn0norm not ignored in save() #789

Closed
gojomo opened this issue Jul 13, 2016 · 1 comment
Closed

Doc2Vec.DocvecsArray.doctag_syn0norm not ignored in save() #789

gojomo opened this issue Jul 13, 2016 · 1 comment
Labels
bug Issue described a bug difficulty easy Easy issue: required small fix

Comments

@gojomo
Copy link
Collaborator

gojomo commented Jul 13, 2016

Unlike with Word2Vec.syn0norm, oversized doctag_syn0norm arrays aren't ignored during native save(). As a result, even if they're a shared-reference to doctag_syn0 after an init_sims(replace=True), both doctag_syn0 and doctag_syn0norm will be written and then read back in, using more storage/RAM than necessary. (See https://groups.google.com/d/msg/gensim/fCcHoZCyV3M/djEZgNWEAAAJ )
@tmylk tmylk closed this as completed in 6238481 Sep 25, 2016
@gojomo
Copy link
Collaborator Author

gojomo commented Sep 26, 2016 •
edited

@tmylk - Commit typo! That commit related to #879 not #789.

@gojomo gojomo reopened this Sep 26, 2016
@tmylk tmylk added bug Issue described a bug difficulty easy Easy issue: required small fix labels Sep 28, 2016
accraze added a commit to accraze/gensim that referenced this issue Dec 22, 2016
@accraze
Fix piskvorky#789 ignore DocvecsArray.doctag_syn0norm in save
d58c09d
@accraze accraze mentioned this issue Dec 22, 2016
Merged
tmylk pushed a commit that referenced this issue Jan 25, 2017
@accraze @tmylk
Fix #789 ignore DocvecsArray.doctag_syn0norm in save (#1053)
3cb735b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issue described a bug difficulty easy Easy issue: required small fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gojomo @tmylk