Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dict save as text #1443

Closed
wants to merge 2 commits into from
Closed

Fix dict save as text #1443

wants to merge 2 commits into from

Conversation

vlejd
Copy link
Contributor

@vlejd vlejd commented Jun 22, 2017 •
edited
Loading

Fixing one of #1441 and last problem in #1402.

It changes tests to not use weird characters.

@piskvorky
Copy link
Owner

piskvorky commented Jun 23, 2017 •
edited
Loading

-1. We don't want to mask errors like this.

@menshikh-iv
Copy link
Contributor

I agree with Radim, we should to understand what's a reason of this behaviour and fix it.

@piskvorky
Copy link
Owner

@vlejd What does 56 mean in the title?

@vlejd
Copy link
Contributor Author

vlejd commented Jul 2, 2017

I reused the branch referring to issue #56 . I will stop doing it.

@piskvorky
Copy link
Owner

piskvorky commented Jul 2, 2017 •
edited
Loading

Yes please, a hyperlink in the PR description to related issues/PRs is much better and more readable.

@piskvorky piskvorky changed the title 56 fix dict save as text Fix dict save as text Jul 2, 2017
@menshikh-iv
Copy link
Contributor

menshikh-iv commented Jul 5, 2017 •
edited
Loading

Ping @vlejd, what's the status of PR?

@menshikh-iv
Copy link
Contributor

menshikh-iv commented Jul 13, 2017 •
edited
Loading

Resolved in #1469.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vlejd @piskvorky @menshikh-iv