-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][GSoC 2018] Similarity Learning #2050
Closed
aneesh-joshi
wants to merge
115
commits into
piskvorky:develop
from
aneesh-joshi:similarity_learning_develop
Closed
Changes from 111 commits
Commits
Show all changes
115 commits
Select commit
Hold shift + click to select a range
e249ed4
handle deprecation
aneesh-joshi 62f6c82
Merge branch 'develop' of https://github.com/RaRe-Technologies/gensim…
aneesh-joshi 1677e98
handle max_count
aneesh-joshi e8c08f8
change flag name
aneesh-joshi 258d033
make flake8 compatible
aneesh-joshi 875c65c
move max_vocab to prepare vocab
aneesh-joshi 0aa8426
correct max_vocab semantics
aneesh-joshi 390f333
remove unnecessary nextline
aneesh-joshi 8c508c7
fix bug and make flake8 complaint
aneesh-joshi c826b19
refactor code and change sorting to key based
aneesh-joshi 35dc681
add tests
aneesh-joshi 67f6a14
introduce effective_min_count
aneesh-joshi 7b1f612
make flake8 compliant
aneesh-joshi fafee70
remove clobbering of min_count
aneesh-joshi 9d99660
remove min_count assertion
aneesh-joshi 6c06fbc
.\gensim\models\word2vec.py
aneesh-joshi c5a0e6e
Revert ".\gensim\models\word2vec.py"
aneesh-joshi fdd2aab
rename max_vocab to max_final_vocab
aneesh-joshi 974d587
update test to max_final_vocab
aneesh-joshi ddb3556
move and modify comment docs
aneesh-joshi c54d8a9
make flake8 compliant
aneesh-joshi f379616
refactor word2vec.py
aneesh-joshi 46d3885
handle possible old model load errors
aneesh-joshi 2cf5625
include effective_min_count tests
aneesh-joshi 8578e3d
make flake compliant
aneesh-joshi a43fea3
remove check for max_final_vocab
aneesh-joshi 340a8cf
include backward compat for 3.3 models
aneesh-joshi 0b62407
remove unnecessary newline
aneesh-joshi 5b7a6c2
add test case for max_final_vocab
aneesh-joshi 48ad4dc
merge master
aneesh-joshi 3cf1e0b
add dssm model and SL vocab class
aneesh-joshi 218d133
add evaluation scripts
aneesh-joshi 93b18f2
refactor code and add write up
aneesh-joshi 90db732
Delete d2v_check.py
aneesh-joshi 7a6e868
Delete d2v_eval.py
aneesh-joshi 82eed4a
Delete eval_theirs.py
aneesh-joshi 8baaae9
Delete predict.test.wikiqa.txtDRMM
aneesh-joshi dc5db12
Delete quora_qp_check.py
aneesh-joshi ba3053a
Delete w2v_avg_eval.py
aneesh-joshi 2af2a83
Update WriteUp 25 May.md
aneesh-joshi 5691116
Update WriteUp 25 May.md
aneesh-joshi 28004ac
add sample mz output
aneesh-joshi 3639619
fix dssm.py, add doctrings and refactor
aneesh-joshi 43829b3
get_data.py
aneesh-joshi 0f58bdf
add get_data.py
aneesh-joshi f6a6175
add unified script for evaluation
aneesh-joshi 9285d76
add evaluation_script
aneesh-joshi 8814a5a
make partially flake8 compliant
aneesh-joshi da4d00b
finish pep8 compliance
aneesh-joshi be348b7
fix line endings and some tox flake issues
aneesh-joshi bf7d0eb
add docstrings and unzipping in get_data
aneesh-joshi 2e4a5a8
add support for saving evaluaton results in a .csv
aneesh-joshi 28fa12f
fix flake8
aneesh-joshi 7600dc4
add support for savinf as csv
aneesh-joshi ff1903e
add drmm_tks
aneesh-joshi 984a025
add writeups, fix hanging indents, add glove download
aneesh-joshi ef73071
Fix minor bug/typo
aneesh-joshi d7c931a
sl_vocab working
aneesh-joshi c4f1818
everythin working
aneesh-joshi 651f532
add list generator, add drmm_tks to evaluation script
aneesh-joshi e96913e
make flake8 compliant
aneesh-joshi fe64ee0
Update Docs
aneesh-joshi cff7fb8
before removing pandas
aneesh-joshi 617f4a4
remove pandas dependency
aneesh-joshi 473030c
add random seed
aneesh-joshi ae50259
remove grabage files
aneesh-joshi 216dc01
add ipynb
aneesh-joshi cab3ac1
clean up
aneesh-joshi 1443ac3
clean further
aneesh-joshi c65beb0
clean further
aneesh-joshi 554833a
remove ipynb checkpoints
aneesh-joshi 5972471
Update setup.py
aneesh-joshi 13a396b
put old ipynb back
aneesh-joshi 55958a4
fix flake and remove unnecessary files
aneesh-joshi d8a1409
remove ipynb checkpoints
aneesh-joshi 9e4554e
move everything to models.experimental
aneesh-joshi 4bbd365
move code further
aneesh-joshi 1b534cc
fix ipynb calls
aneesh-joshi 2e18938
add KeyedVectors, fix vocab building and build from vocab
aneesh-joshi cc440cb
add lazy warning for keras and tf
aneesh-joshi 3e8b8e5
remove lambda layers and add save functionality
aneesh-joshi 07da82b
add custom layer for topk
aneesh-joshi afab56a
add load function
aneesh-joshi ee58169
make requested changes
aneesh-joshi c719939
merge keras and non keras class
aneesh-joshi d56bbc1
remove keep_full_embedding
aneesh-joshi 2de9b55
add params to train for multiple trains
aneesh-joshi 08acdc5
make training iterable
aneesh-joshi 13a51fb
add KeyedVector support as input
aneesh-joshi d556a00
add seeding in general and for each unk word
aneesh-joshi 5f83741
fix docs
aneesh-joshi 2ac7f31
update notebook
aneesh-joshi d6818ee
make some requested changes
aneesh-joshi 256f319
Merge branch 'develop' of https://github.com/RaRe-Technologies/gensim…
aneesh-joshi 5c72137
fix load bug
aneesh-joshi 350f4aa
fix doctests
aneesh-joshi 2e68051
fix module imports
aneesh-joshi 376b28f
add all doctests
aneesh-joshi 0651f44
add some ignored files
aneesh-joshi 5864db0
add drmm_tks test
aneesh-joshi 20fbbfc
fix imports
aneesh-joshi 50386af
fix docs
aneesh-joshi aab50fa
finalize docs
aneesh-joshi 236e4b7
fix typo
aneesh-joshi 66e2385
fix doctests
aneesh-joshi d662bac
fix file name typo
aneesh-joshi 127b441
fix flake
aneesh-joshi 4190b99
add w2v eval in notebook
aneesh-joshi 1299bb7
add evaluate model and complete ipynb
aneesh-joshi 157b7d7
remove models
aneesh-joshi 451e3b1
- adds non model files to docs
aneesh-joshi fd575ea
fix TopK Layer bug
aneesh-joshi 5280853
add drmm
aneesh-joshi 7dec231
get well tuned model
aneesh-joshi 5219d9e
* Tune paramaters to get MAP : 0.60 and
aneesh-joshi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
:mod:`models.experimental.custom_callbacks` -- Custom Callbacks for Similarity Learning | ||
======================================================================================= | ||
|
||
.. automodule:: gensim.models.experimental.custom_callbacks | ||
:synopsis: Custom Callbacks for Similarity Learning | ||
:members: | ||
:inherited-members: | ||
:undoc-members: | ||
:show-inheritance: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
:mod:`models.experimental.custom_layers` -- Custom Layers for Similarity Learning | ||
================================================================================= | ||
|
||
.. automodule:: gensim.models.experimental.custom_layers | ||
:synopsis: Custom Layers for Similarity Learning | ||
:members: | ||
:inherited-members: | ||
:undoc-members: | ||
:show-inheritance: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
:mod:`models.experimental.custom_losses` -- Loss for Similarity Learning | ||
======================================================================== | ||
|
||
.. automodule:: gensim.models.experimental.custom_losses | ||
:synopsis: Loss functions for Similarity Learning | ||
:members: | ||
:inherited-members: | ||
:undoc-members: | ||
:show-inheritance: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
:mod:`models.experimental.drmm_tks` -- Neural Nets for Similarity Learning | ||
========================================================================== | ||
|
||
.. automodule:: gensim.models.experimental.drmm_tks | ||
:synopsis: Neural Network Similarity Learning | ||
:members: | ||
:inherited-members: | ||
:undoc-members: | ||
:show-inheritance: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
:mod:`models.experimental.evaluation_metrics` -- Evaluation Metrics for Similarity Learning | ||
=========================================================================================== | ||
|
||
.. automodule:: gensim.models.experimental.evaluation_metrics | ||
:synopsis: Evaluation Metrics for Similarity Learning | ||
:members: | ||
:inherited-members: | ||
:undoc-members: | ||
:show-inheritance: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need also include other files to documentation building (like callbacks, layers, etc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@menshikh-iv
Please refer to the link below which shows the diff of the requested changes
451e3b1?utf8=%E2%9C%93&diff=unified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note
tox -e docs
will throw errors. Not on my files but on some keras files since I am inheriting from the Keras Layer class which has some unformatted docs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aneesh-joshi that's shouldn't happen (because you include only your files, not Keras), can you show me log of
tox -e docs
that mention the error in some Keras file (not your)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't implemented any of the above functions. Just inherited the Layer class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, looks like you are right (issue with docstring of the parent class that we can't control).
Simple workaround - define these methods yourself and call super (but don't worry much about it now), you have more critical tasks now.