Reuse precalculated updated prior in ldamodel.update_dir_prior
#2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horpto
force-pushed
the
reuse-calculated-values
branch
from
497a476
to
fc4549b
Compare
horpto
force-pushed
the
reuse-calculated-values
branch
from
fc4549b
to
4206850
Compare
menshikh-iv
changed the title
ldamodel.update_dir_prior
piskvorky
reviewed
Dec 12, 2018
| else: | ||
| logger.warning("updated prior not positive") | ||
|
|
||
| logger.warning("updated prior is not positive") |
There was a problem hiding this comment.
Unrelated to this PR, but: shouldn't this be an assert instead? What does such warning mean, what should the user do as a result?
This silent covering of a failure (prior is not actually updated, despite the function name) is unPythonic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.