Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ValueError when instantiating SparseTermSimilarityMatrix #2689

Merged
merged 7 commits into from
Jan 6, 2020
Merged

Fix ValueError when instantiating SparseTermSimilarityMatrix #2689

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2f82e13
force python int before calling islice. islice don't accept numpy int
Nov 27, 2019
40fa7f6
add test to check islice error
Dec 10, 2019
5e8469e
Merge branch 'fix-levenshteinsimilarity-index-error-2688' of https://…
Dec 10, 2019
13dd380
it makes test to fail
Dec 10, 2019
4cb0248
make sure that islice receives a python int
Dec 10, 2019
d4d59a1
Merge remote-tracking branch 'gensim/develop' into fix-levenshteinsim…
Jan 3, 2020
f6c9279
fix typo
Jan 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions gensim/similarities/levenshtein.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
This module provides a namespace for functions that use the Levenshtein distance.
"""

from itertools import islice
import itertools
import logging
from math import floor

Expand Down Expand Up @@ -150,4 +150,4 @@ def most_similar(self, t1, topn=10):
for (similarity, t2) in sorted(similarities, reverse=True)
if similarity > 0
)
return islice(most_similar, topn)
return itertools.islice(most_similar, int(topn))
5 changes: 5 additions & 0 deletions gensim/test/test_similarities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1225,6 +1225,11 @@ def test_most_similar(self):
second_similarities = numpy.array([similarity for term, similarity in index.most_similar(u"holiday", topn=10)])
self.assertTrue(numpy.allclose(first_similarities ** 2.0, second_similarities))

# check propert integration with SparseTermSimilarityMatrix
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# check propert integration with SparseTermSimilarityMatrix
# check proper integration with SparseTermSimilarityMatrix

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a typo. I tried to merge this in, but looks like "allow edit from maintainers" is not enabled.

index = LevenshteinSimilarityIndex(self.dictionary, alpha=1.0, beta=1.0)
similarity_matrix = SparseTermSimilarityMatrix(index, dictionary)
self.assertTrue(scipy.sparse.issparse(similarity_matrix.matrix))


if __name__ == '__main__':
logging.basicConfig(format='%(asctime)s : %(levelname)s : %(message)s', level=logging.DEBUG)
Expand Down