Fixed error message when raising to negative exponent #3232 #3259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate of #3250. |
lelandbatey
reviewed
Oct 30, 2021
| @@ -43,7 +43,7 @@ Features | |||
|
|
|||
| If this feature list left you scratching your head, you can first read | |||
| more about the [Vector Space Model] and [unsupervised document analysis] | |||
| on Wikipedia. | |||
| on Wikipedia. | |||
There was a problem hiding this comment.
In the future I'd suggest leaving out, or removing at the end, unnecessary whitespace changes in documentation.
lelandbatey
reviewed
Oct 30, 2021
| @@ -0,0 +1,8416 @@ | |||
| /* Generated by Cython 0.29.23 */ | |||
There was a problem hiding this comment.
This file seems like it's an auto-generated file which isn't related to this PR. If it is unrelated, then this file should be removed. If this file is related and required for this PR, then the reasons why should be explained in the description of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #3232
In gensim/models/word2vec.py, we changed the line , we type-casted ns_exponent in def make_cum_table(self, domain=2**31 - 1) to a float to allow raising integers to negative exponent.