Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install issues with Poetry #3364

Closed
wants to merge 9 commits into from

Conversation

jaymegordo
Copy link
Contributor

@jaymegordo jaymegordo commented Jul 8, 2022

Fixes #3362.

mpenkov and others added 9 commits April 30, 2022 08:22
Use an environment variable for this since it is often easier to set in a
build wrapper rather than trying to override command-line options in the
right layer of a multi-layer build wrapper and it also requires a lot less
code to do the override.

This will be useful for using alpha versions of Cython or old versions of
Cython provided by the distros or specific versions that fix certain bugs.
Drop COPYING.LESSER as it was moved to COPYING in 2016.

Drop ez_setup.py as it was removed in 2018.

Switch doc2vec_inner.c to doc2vec_inner.cpp,
as it has always been using language=c++.

Suggested-by: setup.py build
Fixes: commit beb04ea
Fixes: commit 2891861
Fixes: commit 1aa11bb
piskvorky#3345)

* Drop reference to Morfessor

It was dropped from usage in 2022.

Fixes: commit acce8a2

* Drop references to tox

Usage of tox was dropped in 2022.

Where necessary, replace tox commands with the current equivalent.

Fixes: commit 3ce81a4

* Drop direct and indirect references to gensim.modules.wrapper(s)

They were all removed in 2021.

TestDtmModel escaped being noticed via test failures because all the tests
it runs are skipped without the DTM_PATH environment variable being set.

Fixes: commit a21d9cc
* disable 3=>4 docs notification

* replace migration docs by sponsorship link
@piskvorky
Copy link
Owner

Please branch off develop, and open your PR against develop. The master branch is stable, only for releases.

@piskvorky piskvorky changed the title Fix 3362 Fix install issues with Poetry Jul 8, 2022
@piskvorky
Copy link
Owner

Wait, I see #3363 now. What is going on?

@jaymegordo jaymegordo closed this Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants