Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show topics #50

Merged
merged 3 commits into from
Sep 18, 2011
Merged

show topics #50

merged 3 commits into from
Sep 18, 2011

Conversation

strongh
Copy link
Contributor

@strongh strongh commented Aug 27, 2011

As discussed in issue #47, added alternative show_topic[s] methods for LSA and LDA model objects. These can now return arrays of array or array of strings, instead of logging formatted strings. Logging is still supported via print_topics, which is now an alias of show_topics with log=True. Should be 100% backward compatible.

@strongh
Copy link
Contributor Author

strongh commented Aug 30, 2011

The second commit makes e.g. doc2bow(['one', 'two', 'two']) equivalent to doc2bow({'one':1, 'two':2}). Let me know if this usage is undesirable, and I can revert it for the purposes of this pull request.

@piskvorky
Copy link
Owner

Yeah the second commit seems unrelated. When you revert it I'll merge, the first commit seems fine :)

piskvorky added a commit that referenced this pull request Sep 18, 2011
@piskvorky piskvorky merged commit f67ac4e into piskvorky:develop Sep 18, 2011
@piskvorky
Copy link
Owner

Merged. Muchas gracias, senor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants