Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep IR tutorial notebook with yelp data #500

Merged
merged 7 commits into from
Nov 5, 2015
Merged

Deep IR tutorial notebook with yelp data #500

merged 7 commits into from
Nov 5, 2015

Conversation

mataddy
Copy link
Contributor

@mataddy mataddy commented Oct 24, 2015

@tmylk @piskvorky follow up on #417 I've added a demo for document classification via the Word2Vec.score function.

@mataddy
Copy link
Contributor Author

mataddy commented Nov 2, 2015

added the fix requested in #470 and updated help

@mataddy
Copy link
Contributor Author

mataddy commented Nov 2, 2015

just adding some extra checks to avoid issues total_sentences is not set properly as in #470

@mataddy
Copy link
Contributor Author

mataddy commented Nov 3, 2015

this should all be good to go

@piskvorky
Copy link
Owner

Looks good @mataddy ! Thanks a lot for the clean up and PR, merging.

@mataddy
Copy link
Contributor Author

mataddy commented Nov 4, 2015

Happy to help; gensim is a blast!

@mataddy
Copy link
Contributor Author

mataddy commented Nov 4, 2015

hey @piskvorky I noticed this didn't merge? let me know if anything came up that you need me to fix.

@piskvorky
Copy link
Owner

Leaving the merge for @tmylk , nothing else to be done from my POW 👍 .

tmylk added a commit that referenced this pull request Nov 5, 2015
Deep IR tutorial notebook with yelp data
@tmylk tmylk merged commit 54e0b6d into piskvorky:develop Nov 5, 2015
@piskvorky
Copy link
Owner

@tmylk this deserves a tweet from @gensim_py too :)

@tmylk
Copy link
Contributor

tmylk commented Nov 6, 2015

Oh yeah. Tweet done.

@mataddy
Copy link
Contributor Author

mataddy commented Nov 6, 2015

awesome, thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants