-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed pattern dependency when it is not needed in order to fix #461 #528
Conversation
return pattern | ||
|
||
|
||
if has_pattern(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, do we even need this if
? When users try to call lemmatize
, and pattern is not installed, they'll get a clear, standard ImportError
.
I'm not sure why this if
is here, I don't think it belongs any more, conceptually. But maybe I'm missing something.
Thanks @ziky90 ! It's a welcome change. Not sure why we even need to mask out |
@piskvorky You're right. I've removed the if and added there check inside Also the non passing test seems to me as not related to changes that I have made. |
@ziky90 before merging, can you also add a note to CHANGELOG summarizing this change? And also mentioning how to deal with the missing |
Information about this PR added to the CHANGELOG. |
@@ -1,6 +1,9 @@ | |||
Changes | |||
======= | |||
|
|||
* Loading of pattern library in utils.py is only in lemmatize function (Jan Zikes, #461) | |||
- utlis.HAS_PATTERN, has also chnged to utils.has_pattern() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utlis
=> utils
, chnged
=> changed
:)
I'm sorry for silly typos :(, anyway typos were fixed. |
Perfect, merging. Thanks @ziky90 |
removed pattern dependency when it is not needed in order to fix #461
This PR should fix the bug described in #461