Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow build_vocab to take progress_per parameter #624

Merged
merged 3 commits into from Apr 3, 2016
Merged

Allow build_vocab to take progress_per parameter #624

merged 3 commits into from Apr 3, 2016

Conversation

zer0n
Copy link
Contributor

@zer0n zer0n commented Mar 3, 2016

Otherwise, it would print out too many lines when training on datasets such as Wikipedia.

@tmylk
Copy link
Contributor

tmylk commented Apr 3, 2016

@zer0n Thanks, that is a useful addition. Sent a PR for changelog note to your branch

@zer0n
Copy link
Contributor Author

zer0n commented Apr 3, 2016

Thanks @tmylk . Merged your changelog.

@tmylk tmylk merged commit 89bee2e into piskvorky:develop Apr 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zer0n @tmylk