Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed default value of lda_initialize to True #676

Merged
merged 1 commit into from
Apr 21, 2016

Conversation

bhargavvader
Copy link
Contributor

@tmylk , with respect to #674.

@bhargavvader
Copy link
Contributor Author

bhargavvader commented Apr 20, 2016

There seems to be a build fail with the glove2word2vec tests. What can be done about it?

This also comes up:

testCalledProcessError (gensim.test.test_dtm.TestDtmModel) ... /home/travis/build/piskvorky/gensim/gensim/corpora/mmcorpus.py:29: ResourceWarning: unclosed file <_io.BufferedReader name='/home/travis/build/piskvorky/gensim/gensim/test/test_data/dtm_test.mm'> matutils.MmReader.__init__(self, fname) skipped '$DTM_PATH is not properly set up.' testDim (gensim.test.test_dtm.TestDtmModel) ... skipped '$DTM_PATH is not properly set up.' testDtm (gensim.test.test_dtm.TestDtmModel) ... skipped '$DTM_PATH is not properly set up.'

Any idea if this is a problem?

@tmylk
Copy link
Contributor

tmylk commented Apr 21, 2016

DTM tests are only run if DTM_PATH env variable is setup.
This variable is not setup in Travis as DTM is not part of the continuous integration.
Did you test your change to DTM on your local machine?

@tmylk
Copy link
Contributor

tmylk commented Apr 21, 2016

Green tests on re-start.

@bhargavvader
Copy link
Contributor Author

I ran the test_dtm.py file on my local, and it is fine - is that all I am supposed to do?

@tmylk tmylk merged commit 4fb424c into piskvorky:develop Apr 21, 2016
@tmylk
Copy link
Contributor

tmylk commented Apr 21, 2016

That's it. Thanks!

@piskvorky
Copy link
Owner

@tmylk the main Travis build is still red (failing TestGlove2Word2Vec) -- please fix ASAP.

@bhargavvader bhargavvader deleted the dtm branch April 28, 2016 00:05
@bhargavvader bhargavvader restored the dtm branch April 28, 2016 00:08
@bhargavvader bhargavvader deleted the dtm branch May 17, 2016 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants