add sample wikidump file and some minimal tests #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes I see that in the Travis now. I think that's during the actual execution, before the assertions. Will dig in a bit when I get back to computer. Are we sure the function runs to completion in 2.6 at all? Possible it just went unnoticed before the tests |
|
@tmylk what is the answer? I'm curious too. |
|
@piskvorky i had a hard time getting anything to work on 2.6 (tho its obviously possible, as travis demonstrates) so i'm no help for you on that question |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
took this file https://dumps.wikimedia.org/enwiki/latest/enwiki-latest-pages-articles1.xml-p000000010p000030302.bz2 and trimmed it
wrote some (very) minimal tests
Addresses this issue: #650