Skip to content

Commit

Permalink
install s3 dependencies by default (#541)
Browse files Browse the repository at this point in the history
* install s3 dependencies by default

* temporarily disable test_package.py

* disable unused import
  • Loading branch information
mpenkov committed Oct 1, 2020
1 parent 6a21ac0 commit d956e22
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 4 deletions.
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
# Unreleased

- Include S3 dependencies by default, because removing them in the 2.2.0 minor release was a mistake.

# 2.2.0, 25 Sep 2020

This release modifies the behavior of setup.py with respect to dependencies.
Previously, `boto3` and other AWS-related packages were installed by default.
Now, in order to install them, you need to run either:

pip install smart_open[aws]
pip install smart_open[s3]

to install the AWS dependencies only, or

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def read(fname):
license='MIT',
platforms='any',

install_requires=install_requires,
install_requires=install_requires + aws_deps,
tests_require=tests_require,
extras_require={
'test': tests_require,
Expand Down
9 changes: 7 additions & 2 deletions smart_open/tests/test_package.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
# -*- coding: utf-8 -*-
import os
# import os
import unittest
import pytest

from smart_open import open

skip_tests = "SMART_OPEN_TEST_MISSING_DEPS" not in os.environ
#
# Temporarily disable these tests while we deal with the fallout of the 2.2.0
# release.
#
# skip_tests = "SMART_OPEN_TEST_MISSING_DEPS" not in os.environ
skip_tests = True


class PackageTests(unittest.TestCase):
Expand Down

0 comments on commit d956e22

Please sign in to comment.