Support for opening pathlib.Path

[clintval]

Would you be willing include support for the standard library Path object?

>>> from pathlib import Path
>>> from smart_open import smart_open

>>> path = Path('~/test.txt').expand_user().resolve()
>>> smart_open(path)

TypeError: don't know how to handle uri PosixPath('/home/user/test.txt')

I would be willing to create the PR! Thanks!

[mpenkov]

Hi! It’s an interesting idea. What would be the benefit over: smart_open.smart_open(str(path)) Or something similar?

…

On Sun, Feb 4, 2018 at 13:04 Clint Valentine ***@***.***> wrote: Would you be willing include support for the standard library Path object? >>> from pathlib import Path>>> from smart_open import smart_open >>> path = Path('~/test.txt').expand_user().resolve()>>> smart_open(path) TypeError: don't know how to handle uri PosixPath('/home/user/test.txt') I would be willing to create the PR! Thanks! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#170>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABDOVFpLewcOh4iLPcJd2v7DMLdY3j_Kks5tRRAsgaJpZM4R4aFu> .

[clintval]

No benefit except for duck-typing.

If parity with open() is a goal of this project than it would make sense for it be supported. No worries if not!

[mpenkov]

If this improves parity, then it makes sense. @menshikh-iv what do you think?

…

On Sun, Feb 4, 2018 at 14:07 Clint Valentine ***@***.***> wrote: No benefit except for duck-typing. If parity with open() is a goal of this project than it would make sense for it be supported. No worries if not! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#170 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABDOVBG1ih5AXU-Ts14ceTCNkce6HV7dks5tRR8CgaJpZM4R4aFu> .

[menshikh-iv]

@mpenkov sounds simple, I agree with @clintval position (if we "mimic" to open - we should add this).