Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package missing __version__ attribute #289

Closed
piskvorky opened this issue Apr 12, 2019 · 0 comments · Fixed by #291
Closed

Package missing __version__ attribute #289

piskvorky opened this issue Apr 12, 2019 · 0 comments · Fixed by #291
Assignees

Comments

@piskvorky
Copy link
Owner

piskvorky commented Apr 12, 2019

It seems we're missing the standard __version__ attribute, so users could check their installed package version:

In [1]: import smart_open; print(smart_open.__version__)
No handlers could be found for logger "smart_open.ssh"
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-1-e26c8ec8e852> in <module>()
----> 1 import smart_open; print(smart_open.__version__)

AttributeError: 'module' object has no attribute '__version__'

(ignore the "No handlers found…", that's a separate issue #288 ).

We should definitely include __version__, same way we do for Gensim etc.

@mpenkov mpenkov self-assigned this Apr 13, 2019
@mpenkov mpenkov mentioned this issue Apr 14, 2019
mpenkov added a commit that referenced this issue Apr 16, 2019
* fix warning, fix #288 
* include VERSION in package_data, fix #289 
* fix #285, add special handling for question marks during url parsing
* add unit test, fix #47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants