Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for passing custom s3 client #149

Closed
wants to merge 1 commit into from
Closed

Added support for passing custom s3 client #149

wants to merge 1 commit into from

Conversation

creatorrr
Copy link

No description provided.

@mpenkov
Copy link
Collaborator

mpenkov commented Dec 13, 2017

@creatorrr Thank you for making the pull request. While in general the change looks OK, I have a few questions:

  • What is the use case for passing a custom S3 client?
  • Is there a benefit to including this as a parameter, as opposed to mocking it?
  • I notice that the top-level interface has not changed. How does the user pass this new parameter?

@menshikh-iv
Copy link
Contributor

Ping @creatorrr

@yganti87
Copy link

Hello @mpenkov - One case I ran into where a custom s3 client needed to be passed was for cross account access using STS. I couldn't find a way of doing this in the current version.

@eschwartz
Copy link
Contributor

Looks like this PR has gone stale, but I also need this functionality (see #199)
Give me a couple days, but I'm going to see if I can get this finished up.

@piskvorky
Copy link
Owner

Fixed by #201.

@piskvorky piskvorky closed this Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants