Travis CI: Add Python 3.7 to the testing #215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.7 on Travis CI added in alignment with travis-ci/travis-ci#9069
|
Thanks for PR @cclauss, several notes
|
menshikh-iv
reviewed
Aug 7, 2018
.travis.yml
Outdated
| script: | ||
| - if [[ ${TRAVIS_SECURE_ENV_VARS} = false ]]; then | ||
| echo "DISABLE INTEGRATION TESTING FOR S3"; | ||
| unset SO_DISABLE_MOCKS; | ||
| unset SO_S3_URL; | ||
| unset SO_S3_RESULT_URL; | ||
| fi | ||
| - if [[ $TRAVIS_PYTHON_VERSION = '*.7' ]]; then |
There was a problem hiding this comment.
@cclauss no need to add flake here, this will be added with other changes & code cleanup later
|
Boto's own tests seem to pass on Python 3.7 boto/boto#3823 The env vars changes did not fix things... Removing the flake8 check. |
|
@cclauss anyway, need to fix this issue with boto first before the merge |
|
@cclauss any ideas how to fix this? |
Merged
|
Already added by #240, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.7 on Travis CI added in alignment with travis-ci/travis-ci#9069