Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing boto keys to be passed directly to smart_open (#35) #38

Merged
merged 4 commits into from
Dec 18, 2015

Commits on Nov 5, 2015

  1. Allowing boto keys to be passed directly to smart_open (piskvorky#35)

    * Updated `smart_open` to accept an instance of boto.s3.key.Key as the
    `uri` parameter.
    * Refactored `S3OpenRead` and `S3OpenWrite` to require only a
    boto.s3.key.Key instance to work, and get the bucket directly from its
    properties. *This is not backwards compatible*.
    * Commented out test `SmartOpenReadTest.test_s3_boto` temporarily.
    asieira committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    c51f8dc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    76c5cf1 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2015

  1. Test and documentation fixes (piskvorky#35)

    Implemented @tmylk ’s recommendations:
    * Fixed `test_s3_boto` by replacing usage of `lookup` with `get_key`
    and re-enabled it;
    * Fixed type checking in the constructors of `HdfsOpenRead` and
    `HdfsOpenWrite`;
    * Updated doctoring to reflect new usage of `smart_open`;
    * Updated CHANGELOG to reflect this change.
    asieira committed Dec 16, 2015
    Configuration menu
    Copy the full SHA
    0ab2d9e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    43e3192 View commit details
    Browse the repository at this point in the history