Fix Travis Build #412
Merged
Fix Travis Build #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petedannemann
changed the title
mpenkov
approved these changes
Jan 30, 2020
mpenkov
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Travis Build
Motivation
#404 made Travis fail due to GCS mocks being enabled when they shouldn't have. We can fix this by changing GCS mocks to toggle from an environment variable specific to GCS instead of the same one as S3.
Odd this didn't fail on the gcs branch, it doesn't look like the Travis build is different for branches and master?
Checklist
Before you create the PR, please make sure you have: