add warning for recently deprecated s3 parameters

CHANGELOG.md

@@ -1,5 +1,8 @@
 # Unreleased
 
+- Add warning for recently deprecated s3 parameters (PR [#618](https://github.com/RaRe-Technologies/smart_open/pull/618), [@mpenkov](https://github.com/mpenkov))
+- Add new top-level compression parameter (PR [#609](https://github.com/RaRe-Technologies/smart_open/pull/609), [@dmcguire81](https://github.com/dmcguire81))
+
 # 5.0.0, 30 Mar 2021
 
 This release modifies the handling of transport parameters for the S3 back-end in a backwards-incompatible way.
@@ -9,7 +12,6 @@ See [the migration docs](MIGRATING_FROM_OLDER_VERSIONS.rst) for details.
 - Fix potential infinite loop when reading from webhdfs (PR [#597](https://github.com/RaRe-Technologies/smart_open/pull/597), [@traboukos](https://github.com/traboukos))
 - Add timeout parameter for http/https (PR [#594](https://github.com/RaRe-Technologies/smart_open/pull/594), [@dustymugs](https://github.com/dustymugs))
 - Remove `tests` directory from package (PR [#589](https://github.com/RaRe-Technologies/smart_open/pull/589), [@e-nalepa](https://github.com/e-nalepa))
-- Add new top-level compression parameter (PR [#609](https://github.com/RaRe-Technologies/smart_open/pull/609), [@dmcguire81](https://github.com/dmcguire81))
 
 # 4.2.0, 15 Feb 2021
 

smart_open/s3.py

@@ -11,6 +11,7 @@
 import functools
 import logging
 import time
+import warnings
 
 try:
     import boto3
@@ -190,6 +191,33 @@ def inject(**kwargs):
 
 
 def open_uri(uri, mode, transport_params):
+    deprecated = (
+        'multipart_upload_kwargs',
+        'object_kwargs',
+        'resource',
+        'resource_kwargs',
+        'session',
+        'singlepart_upload_kwargs',
+    )
+    detected = [k for k in deprecated if k in transport_params]
+    if detected:
+        doc_url = (
+            'https://github.com/RaRe-Technologies/smart_open/blob/develop/'
+            'MIGRATING_FROM_OLDER_VERSIONS.rst'
+        )
+        #
+        # We use warnings.warn /w UserWarning instead of logger.warn here because
+        #
+        # 1) Not everyone has logging enabled; and
+        # 2) check_kwargs (below) already uses logger.warn with a similar message
+        #
+        # https://github.com/RaRe-Technologies/smart_open/issues/614
+        #
+        message = (
+            'ignoring the following deprecated transport parameters: %r. '
+            'See <%s> for details' % (detected, doc_url)
+        )
+        warnings.warn(message, UserWarning)
     parsed_uri = parse_uri(uri)
     parsed_uri, transport_params = _consolidate_params(parsed_uri, transport_params)
     kwargs = smart_open.utils.check_kwargs(open, transport_params)