fix(net): drop special localhost handling #1138
Merged
+1
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is unnecessary to special-case the "localhost" domain name, as documents like RFC 6761 (section 6.3)[1] already define its semantics. It should hence be simply passed to getaddrinfo(), so that the proper loopback address is returned. On the other hand, using "*" as a shorthand for "0.0.0.0" is not universally accepted, so Pistache should continue handle it specifically for backwards compatibility. This restores getaddrinfo() coverage regressed by commit 50e39e1. [1]: https://www.rfc-editor.org/rfc/rfc6761.html#section-6.3
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #1138 +/- ##
==========================================
- Coverage 78.60% 78.47% -0.13%
==========================================
Files 53 53
Lines 6884 6881 -3
==========================================
- Hits 5411 5400 -11
- Misses 1473 1481 +8
☔ View full report in Codecov by Sentry. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is unnecessary to special-case the "localhost" domain name, as documents like RFC 6761 (section 6.3) already define its semantics. It should hence be simply passed to
getaddrinfo(), so that the proper loopback address is returned.On the other hand, using "*" as a shorthand for "0.0.0.0" is not universally accepted, so Pistache should continue handle it specifically for backwards compatibility.
This restores
getaddrinfo()coverage regressed by commit 50e39e1.