build(meson): only build on Linux #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| @@ -252,3 +252,5 @@ int main() { | |||
| ## Project status | |||
|
|
|||
| Pistache hasn't yet hit the 1.0 release. This means that the project is _unstable_ but not _unusable_. In fact, most of the code is production ready; you can use Pistache to develop a RESTful API without issues, but the HTTP client has a few issues in it that make it buggy. | |||
|
|
|||
| <b id="linux-only">\*</b> While most code uses modern C++, Pistache makes use of some Linux-specific APIs where the standard library doesn't provide alternatives, and works only on that OS. See [#6](https://github.com/pistacheio/pistache/issues/6#issuecomment-242398225) for details. If you know how to help, feel free to open an issue! | |||
There was a problem hiding this comment.
There are already lots of open issues. I would reword to "please contribute a PR to add support for your desired platform." Note that such a platform will need automated unit test coverage, which might complicate things.
There was a problem hiding this comment.
Yeah that's better, I didn't know how to word it, thanks :)
Regarding unit tests I think that's a smaller issue. The tests would be the same, as the system calls are an implementation detail; it would be sufficient to run the tests on the supported OS (correct me if I'm wrong)
related to pistacheio#41 related to pistacheio#183 related to pistacheio#760 closes pistacheio#960 related to pistacheio#985 related to pistacheio#6 related to pistacheio#538 related to pistacheio#649 related to pistacheio#741 related to pistacheio#874 closes pistacheio#525
Tachi107
force-pushed
the
meson-linux-only
branch
from
7ce5da3
to
e4c8cfc
Compare
|
I am fine with this PR. Kip, and thoughts? if not, i'll merge it later today. |
|
Deferring here to you @dennisjenkins75. I'm fine with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #41
related to #183
related to #760
closes #960
related to #985
related to #6
related to #538
related to #649
related to #741
related to #874
closes #525