Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyJWT dependency #39

Closed
omgMath opened this issue Jan 6, 2021 · 5 comments
Closed

Update PyJWT dependency #39

omgMath opened this issue Jan 6, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@omgMath
Copy link
Contributor

omgMath commented Jan 6, 2021

PyJWT 2.0.0 was released some days ago (see https://github.com/jpadilla/pyjwt/releases/tag/2.0.0)
It would be nice if we could update to the newest release.

@pitchmuc pitchmuc self-assigned this Jan 10, 2021
@pitchmuc pitchmuc added the enhancement New feature or request label Jan 10, 2021
@pitchmuc
Copy link
Owner

Hello
Have you checked that this is backward compatible ?
It seems to drop support for PyCrypto, that it used and requires a new script.

I understand the request and I will tackle it, so it is using the latest version.
Because it is such an important element of the whole module (and I just got a child) it may take a while before it is updated.

Best,

@omgMath
Copy link
Contributor Author

omgMath commented Jan 11, 2021

Have you checked that this is backward compatible ?

It is not. There is a change titled "Return tokens as string not bytes", so this will imply some changes for this library.

Because it is such an important element of the whole module (and I just got a child) it may take a while before it is updated.

Thank you! And congratulations!

@pitchmuc
Copy link
Owner

Hello
I was able to work on it today and I developed a new branch that I would like you to test before releasing it.
It seems that the encoded JWT returned by the pyJWT 2.0.0 module is not the same (than previous versions) and doesn't support the decode method I have in my current implementation.
Hence, you may had issues.

I hope that this branch will fix the issue. It does in my virtual env but I would like external test as this is critical for the stability of the module.

It is backward compatible.
However, I will not provide support for the retrieveToken method not located in the Login class.

You can find the branch with this head : 2e6be28

@pitchmuc
Copy link
Owner

Thanks for your help on this.
Upgraded with the following commit 832ada2

I will close when release is done on pypi (v 0.2.0)

@pitchmuc
Copy link
Owner

resolve with release of version 0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants