Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stick to one quotation style #7

Closed
Ryuno-Ki opened this issue Nov 6, 2019 · 4 comments
Closed

Stick to one quotation style #7

Ryuno-Ki opened this issue Nov 6, 2019 · 4 comments

Comments

@Ryuno-Ki
Copy link

Ryuno-Ki commented Nov 6, 2019

Normally, you are using single quotes for your dictionaries.
Why do you switch to double ones in https://github.com/pitchmuc/adobe_analytics_api_2.0/blob/04e29001025a6440e972efe6b1b9f292aac956a8/adobe_analytics_2/aanalytics2.py#L81-L85 and following?

@pitchmuc
Copy link
Owner

pitchmuc commented Nov 7, 2019

Honest response : probably because I coded it on a different day with less python and more JS (where I am more used to use double quotation there).
That is a good point for consistency.

@Ryuno-Ki
Copy link
Author

Ryuno-Ki commented Nov 7, 2019

I know what you mean :-D

But a linter can be your friend here ;-)
Or let black do the boring stuff for you.

@pitchmuc
Copy link
Owner

pitchmuc commented Nov 8, 2019

Yes. I feel the important tip there.
I definitely need to do some black magic before releasing my stuff.
I started to work on my new project with someone else and he is a black user... it takes time to get used to tat formatting.
Let's say it is for the greater good :)

@pitchmuc
Copy link
Owner

I finally used black to format my file. :)
I will close that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants