205: ignoring exceptions

Task-Url: #205
pitest · Aug 25, 2022 · 078dc39 · 078dc39
1 parent a95cd0e
commit 078dc39
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 9 deletions.
diff --git a/.../org.pitest.pitclipse.launch.ui/src/org/pitest/pitclipse/launch/ui/PitLaunchShortcut.java b/.../org.pitest.pitclipse.launch.ui/src/org/pitest/pitclipse/launch/ui/PitLaunchShortcut.java
@@ -45,6 +45,7 @@
 import org.eclipse.ui.IEditorPart;
 import org.eclipse.ui.dialogs.ElementListSelectionDialog;
 import org.pitest.pitclipse.core.PitCoreActivator;
+import org.pitest.pitclipse.launch.ui.utils.PitclipseLaunchUiUtils;
 import org.pitest.pitclipse.runner.config.PitConfiguration;
 
 import java.util.List;
@@ -108,24 +109,19 @@ public void launch(ISelection selection, String mode) {
     }
 
     private void launch(Object[] elements, String mode) {
-        try {
+        PitclipseLaunchUiUtils.executeSafely(() -> {
             if (elements.length == 1) {
                 Optional<IJavaElement> selected = asJavaElement(elements[0]);
                 Optional<IJavaElement> launchElement =
                         selected.flatMap(this::getLaunchElementFor);
-
+                
                 if (launchElement.isPresent()) {
                     performLaunch(launchElement.get(), mode);
                 }
-            }
-            else {
+            } else {
                 showNoTestsFoundDialog();
             }
-        } catch (InterruptedException e) { // NOSONAR
-            // OK, silently move on
-        } catch (CoreException e) { // NOSONAR
-            // OK, silently move on
-        }
+        });
     }
 
     private void showNoTestsFoundDialog() {

diff --git a/....pitclipse.launch.ui/src/org/pitest/pitclipse/launch/ui/utils/PitclipseLaunchUiUtils.java b/....pitclipse.launch.ui/src/org/pitest/pitclipse/launch/ui/utils/PitclipseLaunchUiUtils.java
@@ -35,6 +35,11 @@ public static interface RunnableWithCoreException {
         void run() throws CoreException;
     }
 
+    @FunctionalInterface
+    public static interface RunnableWithCoreExceptionInterruptable {
+        void run() throws CoreException, InterruptedException;
+    }
+
     /**
      * Executes the passed lambda and in case of {@link CoreException} sets the
      * error message.
@@ -49,4 +54,19 @@ public static void executeSafely(RunnableWithCoreException runnable, PitMutators
             configurationTab.setErrorMessage(ce.getStatus().getMessage());
         }
     }
+
+    /**
+     * Executes the passed lambda and ignores exceptions.
+     * 
+     * @param runnable
+     */
+    public static void executeSafely(RunnableWithCoreExceptionInterruptable runnable) {
+        try {
+            runnable.run();
+        } catch (InterruptedException e) { // NOSONAR
+            // OK, silently move on
+        } catch (CoreException e) { // NOSONAR
+            // OK, silently move on
+        }
+    }
 }